Changeset 251656 in webkit


Ignore:
Timestamp:
Oct 28, 2019 9:25:17 AM (5 years ago)
Author:
clopez@igalia.com
Message:

[GTK][WPE] Enable CSS typed OM
​https://bugs.webkit.org/show_bug.cgi?id=192875

Reviewed by Carlos Garcia Campos.

.:

This enables the feature when building with experimental features enabled.

  • Source/cmake/OptionsGTK.cmake:
  • Source/cmake/OptionsWPE.cmake:

Source/WebKit:

Enable the runtime feature by default on GTK/WPE when building with
experimental features enabled.

Covered by existing tests.

  • Shared/WebPreferences.yaml:
  • Shared/WebPreferencesDefaultValues.h:

LayoutTests:

Unskip the tests that now pass.

  • platform/gtk/TestExpectations:
  • platform/wpe/TestExpectations:
Location:
trunk
Files:
9 edited

Legend:

Unmodified
Added
Removed

  • trunk/ChangeLog

    r251630 r251656  
     12019-10-28  Carlos Alberto Lopez Perez  <clopez@igalia.com>
     2
     3        [GTK][WPE] Enable CSS typed OM
     4        https://bugs.webkit.org/show_bug.cgi?id=192875
     5
     6        Reviewed by Carlos Garcia Campos.
     7
     8        This enables the feature when building with experimental features enabled.
     9
     10        * Source/cmake/OptionsGTK.cmake:
     11        * Source/cmake/OptionsWPE.cmake:
     12
    1132019-10-26  Chris Lord  <clord@igalia.com>
    214

  • trunk/LayoutTests/ChangeLog

    r251655 r251656  
     12019-10-28  Carlos Alberto Lopez Perez  <clopez@igalia.com>
     2
     3        [GTK][WPE] Enable CSS typed OM
     4        https://bugs.webkit.org/show_bug.cgi?id=192875
     5
     6        Reviewed by Carlos Garcia Campos.
     7
     8        Unskip the tests that now pass.
     9
     10        * platform/gtk/TestExpectations:
     11        * platform/wpe/TestExpectations:
     12
    1132019-10-28  Simon Fraser  <simon.fraser@apple.com>
    214

  • trunk/LayoutTests/platform/gtk/TestExpectations

    r251648 r251656  
    721721css3/scroll-snap [ Skip ]
    722722
    723 # ENABLE(CSS_TYPED_OM) is disabled.
    724 webkit.org/b/192875 css-typedom [ Skip ]
    725 
    726723# ENABLE(CSS_PAINTING_API) is disabled.
    727724webkit.org/b/190710 fast/css-custom-paint [ Skip ]

  • trunk/LayoutTests/platform/wpe/TestExpectations

    r251630 r251656  
    197197# ENABLE_DARK_MODE_CSS is OFF in WPE.
    198198css-dark-mode [ Skip ]
    199 
    200 # ENABLE(CSS_TYPED_OM) is disabled.
    201 webkit.org/b/192875 css-typedom [ Skip ]
    202199
    203200# ENABLE(CSS_PAINTING_API) is disabled

  • trunk/Source/WebKit/ChangeLog

    r251650 r251656  
     12019-10-28  Carlos Alberto Lopez Perez  <clopez@igalia.com>
     2
     3        [GTK][WPE] Enable CSS typed OM
     4        https://bugs.webkit.org/show_bug.cgi?id=192875
     5
     6        Reviewed by Carlos Garcia Campos.
     7
     8        Enable the runtime feature by default on GTK/WPE when building with
     9        experimental features enabled.
     10
     11        Covered by existing tests.
     12
     13        * Shared/WebPreferences.yaml:
     14        * Shared/WebPreferencesDefaultValues.h:
     15
    1162019-10-28  Carlos Garcia Campos  <cgarcia@igalia.com>
    217

  • trunk/Source/WebKit/Shared/WebPreferences.yaml

    r251630 r251656  
    13891389CSSTypedOMEnabled:
    13901390  type: bool
    1391   defaultValue: false
     1391  defaultValue: DEFAULT_CSS_TYPED_OM_ENABLED
    13921392  humanReadableName: "CSS Typed OM"
    13931393  humanReadableDescription: "Enable the CSS Typed OM"

  • trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h

    r251630 r251656  
    283283#endif
    284284
     285#if ENABLE(EXPERIMENTAL_FEATURES) && (PLATFORM(GTK) || PLATFORM(WPE))
     286#define DEFAULT_CSS_TYPED_OM_ENABLED true
     287#else
     288#define DEFAULT_CSS_TYPED_OM_ENABLED false
     289#endif
    285290
    286291#if ENABLE(EXPERIMENTAL_FEATURES) && (PLATFORM(GTK) || PLATFORM(WPE))

  • trunk/Source/cmake/OptionsGTK.cmake

    r251630 r251656  
    164164WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SHAREABLE_RESOURCE PUBLIC ON)
    165165WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEB_RTC PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
     166WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_TYPED_OM PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
    166167
    167168include(GStreamerDependencies)

  • trunk/Source/cmake/OptionsWPE.cmake

    r251630 r251656  
    6161WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEBGL2 PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
    6262WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEB_RTC PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
     63WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_TYPED_OM PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
    6364
    6465# Public options specific to the WPE port. Do not add any options here unless
Note: See TracChangeset for help on using the changeset viewer.