Changeset 251657 in webkit

Timestamp:

Oct 28, 2019 9:59:08 AM (4 years ago)

Author:

graouts@webkit.org

Message:

[Web Animations] The easing property for a CSSTransition effect is always "linear"
​https://bugs.webkit.org/show_bug.cgi?id=203476

Reviewed by Dean Jackson.

LayoutTests/imported/w3c:

Mark WPT progressions.

• web-platform-tests/css/css-transitions/AnimationEffect-getComputedTiming.tentative-expected.txt:

Source/WebCore:

While we correctly used the timing function set on the Animation object created while parsing a CSS Transition
for blending, we wouldn't set the timing function on the CSSTransition's AnimationEffect and it would not be
reflected correctly through the JS API. This also means that we shouldn't perform per-keyframe blending for CSS
Transitions.

• animation/CSSTransition.cpp:

(WebCore::CSSTransition::setTimingProperties):

• animation/KeyframeEffect.cpp:

(WebCore::KeyframeEffect::setAnimatedPropertiesInStyle):

Location:

trunk

Files:

• LayoutTests/imported/w3c/ChangeLog (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/AnimationEffect-getComputedTiming.tentative-expected.txt (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/animation/CSSTransition.cpp (modified) (1 diff)
• Source/WebCore/animation/KeyframeEffect.cpp (modified) (2 diffs)

trunk/LayoutTests/imported/w3c/ChangeLog

@@ +1 @@
+2019-10-27  Antoine Quint  <graouts@apple.com>
+
+        [Web Animations] The easing property for a CSSTransition effect is always "linear"
+        https://bugs.webkit.org/show_bug.cgi?id=203476
+
+        Reviewed by Dean Jackson.
+
+        Mark WPT progressions.
+
+        * web-platform-tests/css/css-transitions/AnimationEffect-getComputedTiming.tentative-expected.txt:
+
 2019-10-28  Simon Fraser  <simon.fraser@apple.com>
 

trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/AnimationEffect-getComputedTiming.tentative-expected.txt

@@ -9 +9 @@
 PASS duration of a new transition 
 PASS direction of a new transition 
-FAIL easing of a new transition assert_equals: Initial value of easing expected "ease" but got "linear"
-FAIL non-default easing of a new transition assert_equals: Initial value of easing expected "steps(4)" but got "linear"
+PASS easing of a new transition 
+PASS non-default easing of a new transition 
 PASS endTime of a new transition 
 PASS activeDuration of a new transition 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-10-27  Antoine Quint  <graouts@apple.com>
+
+        [Web Animations] The easing property for a CSSTransition effect is always "linear"
+        https://bugs.webkit.org/show_bug.cgi?id=203476
+
+        Reviewed by Dean Jackson.
+
+        While we correctly used the timing function set on the Animation object created while parsing a CSS Transition
+        for blending, we wouldn't set the timing function on the CSSTransition's AnimationEffect and it would not be
+        reflected correctly through the JS API. This also means that we shouldn't perform per-keyframe blending for CSS
+        Transitions.
+
+        * animation/CSSTransition.cpp:
+        (WebCore::CSSTransition::setTimingProperties):
+        * animation/KeyframeEffect.cpp:
+        (WebCore::KeyframeEffect::setAnimatedPropertiesInStyle):
+
 2019-10-28  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/animation/CSSTransition.cpp

@@ -73 +73 @@
     animationEffect->setDelay(delay);
     animationEffect->setIterationDuration(duration);
+    animationEffect->setTimingFunction(backingAnimation().timingFunction());
 
     unsuspendEffectInvalidation();

trunk/Source/WebCore/animation/KeyframeEffect.cpp

@@ -1066 +1066 @@
 
     bool isCSSAnimation = is<CSSAnimation>(animation());
+    bool isCSSTransition = is<CSSTransition>(animation());
 
     for (auto cssPropertyId : m_blendingKeyframes.properties()) {
@@ -1184 +1185 @@
         // 17. Let transformed distance be the result of evaluating the timing function associated with the first keyframe in interval endpoints
         //     passing interval distance as the input progress.
+        // We do not need to do this for CSS Transitions since the timing function is applied to the AnimationEffect as a whole and thus
+        // iterationProgress is already transformed.
         auto transformedDistance = intervalDistance;
-        if (startKeyframeIndex) {
+        if (!isCSSTransition && startKeyframeIndex) {
             if (auto duration = iterationDuration()) {
                 auto rangeDuration = (endOffset - startOffset) * duration.seconds();