Changeset 251804 in webkit


Ignore:
Timestamp:
Oct 30, 2019 2:30:39 PM (5 years ago)
Author:
Simon Fraser
Message:

REGRESSION (r251750): Three CSS Tests are Failing
https://bugs.webkit.org/show_bug.cgi?id=203616
<rdar://problem/56749907>

Unreviewed test gardening.

Fix the conic-gradient-parsing.html tests, and update iOS expectations for two hsl tests.

  • http/wpt/css/css-images-4/conic-gradient-parsing.html:
  • platform/ios/fast/css/hsl-color-expected.txt:
  • platform/ios/fast/css/hsla-color-expected.txt:
Location:
trunk/LayoutTests
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r251799 r251804  
     12019-10-30  Simon Fraser  <simon.fraser@apple.com>
     2
     3        REGRESSION (r251750): Three CSS Tests are Failing
     4        https://bugs.webkit.org/show_bug.cgi?id=203616
     5        <rdar://problem/56749907>
     6
     7        Unreviewed test gardening.
     8
     9        Fix the conic-gradient-parsing.html tests, and update iOS expectations for two hsl tests.
     10
     11        * http/wpt/css/css-images-4/conic-gradient-parsing.html:
     12        * platform/ios/fast/css/hsl-color-expected.txt:
     13        * platform/ios/fast/css/hsla-color-expected.txt:
     14
    1152019-10-30  Zalan Bujtas  <zalan@apple.com>
    216
  • trunk/LayoutTests/http/wpt/css/css-images-4/conic-gradient-parsing.html

    r237402 r251804  
    4040    testGradient("conic-gradient(white -50%, black 150%)");
    4141    testGradient("conic-gradient(white -180deg, black 540deg)");
    42     testGradient("conic-gradient(hsl(0,0%,75%), hsl(0,0%,25%))", "conic-gradient(rgb(191, 191, 191), rgb(63, 63, 63))");
     42    testGradient("conic-gradient(hsl(0,0%,75%), hsl(0,0%,25%))", "conic-gradient(rgb(191, 191, 191), rgb(64, 64, 64))");
    4343    testGradient("conic-gradient(from 45deg, white, black, white)");
    4444    testGradient("conic-gradient(hsl(0,0%,87.5%), white 45deg, black 225deg, hsl(0,0%,87.5%))", "conic-gradient(rgb(223, 223, 223), white 45deg, black 225deg, rgb(223, 223, 223))");
  • trunk/LayoutTests/platform/ios/fast/css/hsl-color-expected.txt

    r179104 r251804  
    1616        RenderText {#text} at (0,1) size 570x36
    1717          text run at (0,1) width 570: "This should be blue: hsl(240, 100%, 50%)"
    18       RenderBlock {H1} at (0,237) size 784x39 [color=#7FFF7F]
     18      RenderBlock {H1} at (0,237) size 784x39 [color=#80FF80]
    1919        RenderText {#text} at (0,1) size 657x36
    2020          text run at (0,1) width 657: "This should be light green: hsl(120, 100%, 75%)"
    21       RenderBlock {H1} at (0,297) size 784x39 [color=#007F00]
     21      RenderBlock {H1} at (0,297) size 784x39 [color=#008000]
    2222        RenderText {#text} at (0,1) size 660x36
    2323          text run at (0,1) width 660: "This should be dark green: hsl(120, 100%, 25%)"
    24       RenderBlock {H1} at (0,356) size 784x39 [color=#3FBF3F]
     24      RenderBlock {H1} at (0,356) size 784x39 [color=#40BF40]
    2525        RenderText {#text} at (0,1) size 659x36
    2626          text run at (0,1) width 659: "This should be pastel green: hsl(120, 50%, 50%)"
     
    4141        RenderText {#text} at (0,0) size 480x19
    4242          text run at (0,0) width 480: "Check percentages less than 0% (negative values), should be limited to 0%"
    43       RenderBlock {H1} at (0,637) size 784x39 [color=#7F7F7F]
     43      RenderBlock {H1} at (0,637) size 784x39 [color=#808080]
    4444        RenderText {#text} at (0,1) size 539x36
    4545          text run at (0,1) width 539: "This should be grey: hsl(120, 0%, 50%)"
    46       RenderBlock {H1} at (0,697) size 784x39 [color=#7F7F7F]
     46      RenderBlock {H1} at (0,697) size 784x39 [color=#808080]
    4747        RenderText {#text} at (0,1) size 638x36
    4848          text run at (0,1) width 638: "This should be grey, too: hsl(120, -100%, 50%)"
     
    5151          text run at (0,0) width 781: "Check Hue values that are larger than 360, should be normalized back to a value between 0 and 360. As Hue values are in"
    5252          text run at (0,20) width 444: "degrees, there is no maximum like percentages, they are loop around."
    53       RenderBlock {H1} at (0,818) size 784x39 [color=#007F00]
     53      RenderBlock {H1} at (0,818) size 784x39 [color=#008000]
    5454        RenderText {#text} at (0,1) size 660x36
    5555          text run at (0,1) width 660: "This should be dark green: hsl(120, 100%, 25%)"
    56       RenderBlock {H1} at (0,877) size 784x39 [color=#007F00]
     56      RenderBlock {H1} at (0,877) size 784x39 [color=#008000]
    5757        RenderText {#text} at (0,1) size 719x36
    5858          text run at (0,1) width 719: "This should be dark green, too: hsl(480, 100%, 25%)"
     
    6060        RenderText {#text} at (0,0) size 261x19
    6161          text run at (0,0) width 261: "Check Hue values with a negative angle."
    62       RenderBlock {H1} at (0,978) size 784x39 [color=#7FFF7F]
     62      RenderBlock {H1} at (0,978) size 784x39 [color=#80FF80]
    6363        RenderText {#text} at (0,1) size 657x36
    6464          text run at (0,1) width 657: "This should be light green: hsl(120, 100%, 75%)"
    65       RenderBlock {H1} at (0,1037) size 784x39 [color=#7FFF7F]
     65      RenderBlock {H1} at (0,1037) size 784x39 [color=#80FF80]
    6666        RenderText {#text} at (0,1) size 726x36
    6767          text run at (0,1) width 726: "This should be light green, too: hsl(-240, 100%, 75%)"
    68       RenderBlock {H1} at (0,1097) size 784x39 [color=#7FFF7F]
     68      RenderBlock {H1} at (0,1097) size 784x39 [color=#80FF80]
    6969        RenderText {#text} at (0,1) size 726x36
    7070          text run at (0,1) width 726: "This should be light green, too: hsl(-600, 100%, 75%)"
  • trunk/LayoutTests/platform/ios/fast/css/hsla-color-expected.txt

    r179104 r251804  
    44  RenderBlock {HTML} at (0,0) size 800x600
    55    RenderBody {BODY} at (8,8) size 784x571 [bgcolor=#FFFF00]
    6       RenderBlock {H1} at (0,0) size 784x38 [color=#FF00007F]
     6      RenderBlock {H1} at (0,0) size 784x38 [color=#FF000080]
    77        RenderText {#text} at (0,1) size 394x36
    88          text run at (0,1) width 394: "This should be red, alpha 0.5"
    9       RenderBlock {H1} at (0,59) size 784x39 [color=#FF00007F]
     9      RenderBlock {H1} at (0,59) size 784x39 [color=#FF000080]
    1010        RenderText {#text} at (0,1) size 455x36
    1111          text run at (0,1) width 455: "This should also be red, alpha 0.5"
Note: See TracChangeset for help on using the changeset viewer.