Context Navigation

Changeset 25188 in webkit

Timestamp:

Aug 22, 2007 1:10:40 PM (17 years ago)

Author:

kmccullo

Message:

LayoutTests:

Reviewed by Adele.

WebCore:

Reviewed by Adele.

Location:

trunk

Files:

-                      r25186
+                      r25188
+-08-22  Kevin McCullough  <kmccullough@apple.com>
+        Reviewed by Adele.
+        - rdar:5423067 Reapplying the change but only when the text area is in focus.
+        * fast/forms/cursor-position-expected.txt:
+        * fast/forms/cursor-position.html:
 -08-22  Kevin McCullough  <kmccullough@apple.com>

-                      r25186
+                      r25188
 This test sets a non-standard line endings, sets selection, then sets a standard line ending string, and checks selection.
+This test used to check that the selection start was the same before and after a change to the contents of a textarea.
+If this test succeeded, you should see 2 lines saying "10, 10" below.
+However now, in order to match the behavior of the other major browsers, selection is moved to the end of the text value when a change occurs to the contents of a text area.
+Because this would invalidate the previous test, and that the previous test now perfectly shows the new behavior, we repurposed it.
+, 10
+, 10
+rdar://problem/5423067 gmail is super annoying when trying to add a new name to the TO, CC or BCC fields
+, 25
+, 24

-                      r25186
+                      r25188
                     layoutTestController.dumpAsText();
+                }
                 var elt = document.getElementById("text");
                 txt = "this is\ra test\rof cursor";
 …
     </head>
     <body onload="test();">
+        <p>This test sets a non-standard line endings, sets selection, then sets a standard line ending string, and checks selection.</p>
+        <p>If this test succeeded, you should see 2 lines saying "10, 10" below.</p>
+        <p>This test used to check that the selection start was the same before and after a change to the contents of a textarea.</p>
+        <p>However now, in order to match the behavior of the other major browsers, selection is moved to the end of the text value when a change occurs to the contents of a text area.</p>
+        <p>Because this would invalidate the previous test, and that the previous test now perfectly shows the new behavior, we repurposed it.</p>
+        <br />
+        <p>rdar://problem/5423067 gmail is super annoying when trying to add a new name to the TO, CC or BCC fields</p>
         <hr />
         <form>

-                      r25187
+                      r25188
+-08-22  Kevin McCullough  <kmccullough@apple.com>
+        Reviewed by Adele.
+        - rdar:5423067 Reapplyingthe change but only when the text area is in focus.
+        * html/HTMLTextAreaElement.cpp:
+        (WebCore::HTMLTextAreaElement::setValue):
 -08-21  David Hyatt  <hyatt@apple.com>

-                      r25186
+                      r25188
     if (renderer())
         renderer()->updateFromElement();
+    // Restore a caret at the starting point of the old selection.
+    // This matches Safari 2.0 behavior.
+    if (document()->focusedNode() == this && cachedSelStart != -1) {
+        ASSERT(cachedSelEnd != -1);
+        setSelectionRange(cachedSelStart, cachedSelStart);
+    // Set the caret to the end of the text value.
+    if (document()->focusedNode() == this) {
+        unsigned endOfString = m_value.length();
+        setSelectionRange(endOfString, endOfString);
+    }
     setChanged();
+}

Note: See TracChangeset for help on using the changeset viewer.