Changeset 251901 in webkit

Timestamp:

Oct 31, 2019 6:39:43 PM (4 years ago)

Author:

Jonathan Bedard

Message:

REGRESSION (r251808): run-webkit-test cannot show results.html
​https://bugs.webkit.org/show_bug.cgi?id=203709
<rdar://problem/56798620>

Reviewed by Stephanie Lewis.

• Scripts/webkitpy/port/darwin.py:

(DarwinPort.show_results_html_file): os.devnull is a string, not a file.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/port/darwin.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2019-10-31  Jonathan Bedard  <jbedard@apple.com>
+
+        REGRESSION (r251808): run-webkit-test cannot show results.html
+        https://bugs.webkit.org/show_bug.cgi?id=203709
+        <rdar://problem/56798620>
+
+        Reviewed by Stephanie Lewis.
+
+        * Scripts/webkitpy/port/darwin.py:
+        (DarwinPort.show_results_html_file): os.devnull is a string, not a file.
+
 2019-10-31  Matt Baker  <mattbaker@apple.com>
 

trunk/Tools/Scripts/webkitpy/port/darwin.py

@@ -85 +85 @@
         # to exit and we want the output to show up on stdout in case there are errors
         # launching the browser.
-        self._executive.popen([self.path_to_script('run-safari')] + self._arguments_for_configuration() + ['--no-saved-state', '-NSOpen', results_filename],
-            cwd=self.webkit_base(), stdout=os.devnull, stderr=os.devnull)
+        with open(os.devnull) as devnull:
+            self._executive.popen([self.path_to_script('run-safari')] + self._arguments_for_configuration() + ['--no-saved-state', '-NSOpen', results_filename],
+                cwd=self.webkit_base(), stdout=devnull, stderr=devnull)
 
     @memoized