Changeset 251915 in webkit

Timestamp:

Nov 1, 2019 7:26:16 AM (4 years ago)

Author:

Fujii Hironori

Message:

[CMake] TestWebCore shouldn't link with WebCoreTestSupport
​https://bugs.webkit.org/show_bug.cgi?id=203672

Reviewed by Don Olmstead.

TestWebCore doesn't need to link with WebCoreTestSupport. And, it
causes a problem for Windows because WebCoreTestSupport imports
WebCore symbols by using dllimport, however, WebCore is not a DLL.
(Bug 203663 Comment 4)

• TestWebKitAPI/CMakeLists.txt: Changed TestWebCore not to link

with WebCoreTestSupport. Changed TestWebCore to link with
WebCoreHeaderInterface instead.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• TestWebKitAPI/CMakeLists.txt (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2019-11-01  Fujii Hironori  <Hironori.Fujii@sony.com>
+
+        [CMake] TestWebCore shouldn't link with WebCoreTestSupport
+        https://bugs.webkit.org/show_bug.cgi?id=203672
+
+        Reviewed by Don Olmstead.
+
+        TestWebCore doesn't need to link with WebCoreTestSupport. And, it
+        causes a problem for Windows because WebCoreTestSupport imports
+        WebCore symbols by using dllimport, however, WebCore is not a DLL.
+        (Bug 203663 Comment 4)
+
+        * TestWebKitAPI/CMakeLists.txt: Changed TestWebCore not to link
+        with WebCoreTestSupport. Changed TestWebCore to link with
+        WebCoreHeaderInterface instead.
+
 2019-10-31  Jonathan Bedard  <jbedard@apple.com>
 

trunk/Tools/TestWebKitAPI/CMakeLists.txt

@@ -148 +148 @@
 
     set(TestWebCore_LIBRARIES
-        WebCoreTestSupport
         gtest
     )
     if (NOT APPLE)
-        list(APPEND TestWebCore_LIBRARIES WebCore)
+        list(APPEND TestWebCore_LIBRARIES WebCore WebCoreHeaderInterface)
     endif ()