Changeset 251954 in webkit

Timestamp:

Nov 1, 2019 4:55:12 PM (5 years ago)

Author:

commit-queue@webkit.org

Message:

Mark VeryLow priority requests using a request dictionary key
​https://bugs.webkit.org/show_bug.cgi?id=203594

Patch by Benjamin Nham <Ben Nham> on 2019-11-01
Reviewed by Alex Christensen.

Mark very-low-pri beacon/ping loads using a request dictionary key. PLT currently ignores
these loads by checking if a request's CFURLRequestPriority is 0, but that won't work
anymore once I make VeryLow and Low pri requests both have a priority of 0 for
​https://bugs.webkit.org/show_bug.cgi?id=203423.

• platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::ResourceRequest::doUpdatePlatformRequest):

• platform/network/cocoa/ResourceRequestCocoa.mm:

(WebCore::ResourceRequest::doUpdatePlatformRequest):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/network/cf/ResourceRequestCFNet.cpp (modified) (1 diff)
• platform/network/cocoa/ResourceRequestCocoa.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-11-01  Benjamin Nham  <nham@apple.com>
+
+        Mark VeryLow priority requests using a request dictionary key
+        https://bugs.webkit.org/show_bug.cgi?id=203594
+
+        Reviewed by Alex Christensen.
+
+        Mark very-low-pri beacon/ping loads using a request dictionary key. PLT currently ignores
+        these loads by checking if a request's CFURLRequestPriority is 0, but that won't work
+        anymore once I make VeryLow and Low pri requests both have a priority of 0 for
+        https://bugs.webkit.org/show_bug.cgi?id=203423.
+
+        * platform/network/cf/ResourceRequestCFNet.cpp:
+        (WebCore::ResourceRequest::doUpdatePlatformRequest):
+        * platform/network/cocoa/ResourceRequestCocoa.mm:
+        (WebCore::ResourceRequest::doUpdatePlatformRequest):
+
 2019-11-01  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/platform/network/cf/ResourceRequestCFNet.cpp

@@ -194 +194 @@
         CFURLRequestSetShouldPipelineHTTP(cfRequest, true, true);
 
-    if (resourcePrioritiesEnabled())
+    if (resourcePrioritiesEnabled()) {
         CFURLRequestSetRequestPriority(cfRequest, toPlatformRequestPriority(priority()));
+
+        // Used by PLT to ignore very low priority beacon and ping loads.
+        if (priority() == ResourceLoadPriority::VeryLow)
+            _CFURLRequestSetProtocolProperty(cfRequest, CFSTR("WKVeryLowLoadPriority"), kCFBooleanTrue);
+    }
 
     setHeaderFields(cfRequest, httpHeaderFields());

trunk/Source/WebCore/platform/network/cocoa/ResourceRequestCocoa.mm

@@ -170 +170 @@
         CFURLRequestSetShouldPipelineHTTP([nsRequest _CFURLRequest], true, true);
 
-    if (ResourceRequest::resourcePrioritiesEnabled())
+    if (ResourceRequest::resourcePrioritiesEnabled()) {
         CFURLRequestSetRequestPriority([nsRequest _CFURLRequest], toPlatformRequestPriority(priority()));
+
+        // Used by PLT to ignore very low priority beacon and ping loads.
+        if (priority() == ResourceLoadPriority::VeryLow)
+            _CFURLRequestSetProtocolProperty([nsRequest _CFURLRequest], CFSTR("WKVeryLowLoadPriority"), kCFBooleanTrue);
+    }
 
     [nsRequest setCachePolicy:toPlatformRequestCachePolicy(cachePolicy())];