Changeset 251996 in webkit

Timestamp:

Nov 4, 2019 9:50:36 AM (4 years ago)

Author:

commit-queue@webkit.org

Message:

Flaky API Test TestWebKitAPI.WebKit.UploadDirectory
​https://bugs.webkit.org/show_bug.cgi?id=203652

Patch by Alex Christensen <​achristensen@webkit.org> on 2019-11-04
Reviewed by Alexey Proskuryakov.

It is not important that the directory to upload does not exist before the test starts.
Make the test more robust to state left behind by previous iterations of this test by removing the check.
The important check in this test is the uploaded body size.

• TestWebKitAPI/Tests/WebKitCocoa/UploadDirectory.mm:

(TEST):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• TestWebKitAPI/Tests/WebKitCocoa/UploadDirectory.mm (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2019-11-04  Alex Christensen  <achristensen@webkit.org>
+
+        Flaky API Test TestWebKitAPI.WebKit.UploadDirectory
+        https://bugs.webkit.org/show_bug.cgi?id=203652
+
+        Reviewed by Alexey Proskuryakov.
+
+        It is not important that the directory to upload does not exist before the test starts.
+        Make the test more robust to state left behind by previous iterations of this test by removing the check.
+        The important check in this test is the uploaded body size.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/UploadDirectory.mm:
+        (TEST):
+
 2019-11-04  Kate Cheney  <katherine_cheney@apple.com>
 

trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/UploadDirectory.mm

@@ -73 +73 @@
     NSError *error = nil;
     NSURL *directory = [NSURL fileURLWithPath:[NSTemporaryDirectory() stringByAppendingPathComponent:@"UploadDirectory"] isDirectory:YES];
-    EXPECT_FALSE([fileManager fileExistsAtPath:directory.path]);
+    [fileManager removeItemAtPath:directory.path error:nil];
     EXPECT_TRUE([fileManager createDirectoryAtURL:directory withIntermediateDirectories:YES attributes:nil error:&error]);
     EXPECT_FALSE(error);