Changeset 252086 in webkit

Timestamp:

Nov 5, 2019 2:57:46 PM (4 years ago)

Author:

Fujii Hironori

Message:

.:
[Win][CMake] Build WebCore as an OBJECT library for WinCairo port
​https://bugs.webkit.org/show_bug.cgi?id=203663

Reviewed by Ross Kirsling.

WebCore is using declspec(dllexport) to export symbols, but it
is built as a static library rather than a DLL. If any symbols in
an object file aren't referenced from WebKit.dll, they won't be
included in WebKit.dll.

This issue can be solved either by using OBJECT library for
WebCore or using /WHOLEARCHIVE:WebCore.lib for WebKit.

This change takes OBJECT library approach becuase it doesn't
generate unnecessary static libs (WebCore.lib) and it's already
used for non-unified source builds for the library size issue (Bug
196866 Comment 4).

However, AppleWin can't use it because the Apple internal builds
need to generate the static libs and OBJECT library doesn't work
well with makesafeseh.obj.

• Source/cmake/OptionsWin.cmake: Removed code overriding library types.
• Source/cmake/OptionsWinCairo.cmake: Use OBJECT library types for WebCore and WebCoreTestSupport.

Source/WebCore:
[Win][CMake] Build WebCore as an OBJECT library unless Apple internal builds
​https://bugs.webkit.org/show_bug.cgi?id=203663

Reviewed by Ross Kirsling.

No behavioral changes.

• CMakeLists.txt: Changed WebCoreTestSupport not to link with

WebCore for Windows. Because WebKit.dll exports WebCore symbols,
they will be duplicated with WebCore.

Location:

trunk

Files:

• ChangeLog (modified) (1 diff)
• Source/WebCore/CMakeLists.txt (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/cmake/OptionsWin.cmake (modified) (1 diff)
• Source/cmake/OptionsWinCairo.cmake (modified) (1 diff)

trunk/ChangeLog

@@ +1 @@
+2019-11-05  Fujii Hironori  <Hironori.Fujii@sony.com>
+
+        [Win][CMake] Build WebCore as an OBJECT library for WinCairo port
+        https://bugs.webkit.org/show_bug.cgi?id=203663
+
+        Reviewed by Ross Kirsling.
+
+        WebCore is using __declspec(dllexport) to export symbols, but it
+        is built as a static library rather than a DLL. If any symbols in
+        an object file aren't referenced from WebKit.dll, they won't be
+        included in WebKit.dll.
+
+        This issue can be solved either by using OBJECT library for
+        WebCore or using /WHOLEARCHIVE:WebCore.lib for WebKit.
+
+        This change takes OBJECT library approach becuase it doesn't
+        generate unnecessary static libs (WebCore.lib) and it's already
+        used for non-unified source builds for the library size issue (Bug
+        196866 Comment 4).
+
+        However, AppleWin can't use it because the Apple internal builds
+        need to generate the static libs and OBJECT library doesn't work
+        well with makesafeseh.obj.
+
+        * Source/cmake/OptionsWin.cmake: Removed code overriding library types.
+        * Source/cmake/OptionsWinCairo.cmake: Use OBJECT library types for WebCore and WebCoreTestSupport.
+
 2019-11-02  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebCore/CMakeLists.txt

@@ -1231 +1231 @@
 
 set(WebCoreTestSupport_LIBRARIES
-    WebCore
     WebKit::JavaScriptCore
 )
+if (NOT WTF_OS_WINDOWS)
+    list(APPEND WebCoreTestSupport_LIBRARIES WebCore)
+endif ()
 
 if (ENABLE_LEGACY_ENCRYPTED_MEDIA)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-11-05  Fujii Hironori  <Hironori.Fujii@sony.com>
+
+        [Win][CMake] Build WebCore as an OBJECT library unless Apple internal builds
+        https://bugs.webkit.org/show_bug.cgi?id=203663
+
+        Reviewed by Ross Kirsling.
+
+        No behavioral changes.
+
+        * CMakeLists.txt: Changed WebCoreTestSupport not to link with
+        WebCore for Windows. Because WebKit.dll exports WebCore symbols,
+        they will be duplicated with WebCore.
+
 2019-11-05  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Source/cmake/OptionsWin.cmake

@@ -162 +162 @@
 set(WebKitLegacy_LIBRARY_TYPE SHARED)
 
-if (NOT ENABLE_UNIFIED_BUILDS)
-    if (WebCore_LIBRARY_TYPE MATCHES STATIC)
-        set(WebCore_LIBRARY_TYPE OBJECT)
-    endif ()
-    if (WebCoreTestSupport_LIBRARY_TYPE MATCHES STATIC)
-        set(WebCoreTestSupport_LIBRARY_TYPE OBJECT)
-    endif ()
-endif ()
-
 # If <winsock2.h> is not included before <windows.h> redefinition errors occur
 # unless _WINSOCKAPI_ is defined before <windows.h> is included

trunk/Source/cmake/OptionsWinCairo.cmake

@@ -65 +65 @@
 set(WTF_SCRIPTS_DIR ${CMAKE_BINARY_DIR}/WTF/Scripts)
 set(JavaScriptCore_SCRIPTS_DIR ${CMAKE_BINARY_DIR}/JavaScriptCore/Scripts)
+
+# Override library types
+set(WebCore_LIBRARY_TYPE OBJECT)
+set(WebCoreTestSupport_LIBRARY_TYPE OBJECT)