Changeset 252150 in webkit

Timestamp:

Nov 6, 2019 2:21:33 PM (5 years ago)

Author:

aakash_jain@apple.com

Message:

All EWS status-bubbles shows #1 on security patches when patch is uploaded with webkit-patch --no-review
​https://bugs.webkit.org/show_bug.cgi?id=203903

Reviewed by David Kilzer.

• BuildSlaveSupport/ews-app/ews/fetcher.py:

(BugzillaPatchFetcher.fetch):

Location:

trunk/Tools

Files:

• BuildSlaveSupport/ews-app/ews/fetcher.py (modified) (2 diffs)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/ews-app/ews/fetcher.py

@@ -64 +64 @@
 
         for patch_id in patches_to_send:
-            if Patch.is_patch_sent_to_buildbot(patch_id):
-                _log.error('Patch {} is already sent to buildbot.'.format(patch_id))
-                continue
-            Patch.set_sent_to_buildbot(patch_id, True)
             bz_patch = Bugzilla.retrieve_attachment(patch_id)
             if not bz_patch or bz_patch['id'] != patch_id:
@@ -76 +72 @@
                 Patch.set_obsolete(patch_id)
                 continue
+            if Patch.is_patch_sent_to_buildbot(patch_id):
+                _log.error('Patch {} is already sent to buildbot.'.format(patch_id))
+                continue
+            Patch.set_sent_to_buildbot(patch_id, True)
             rc = Buildbot.send_patch_to_buildbot(bz_patch['path'],
                      properties=['patch_id={}'.format(patch_id), 'bug_id={}'.format(bz_patch['bug_id']), 'owner={}'.format(bz_patch.get('creator', ''))])

trunk/Tools/ChangeLog

@@ +1 @@
+2019-11-06  Aakash Jain  <aakash_jain@apple.com>
+
+        All EWS status-bubbles shows #1 on security patches when patch is uploaded with webkit-patch --no-review
+        https://bugs.webkit.org/show_bug.cgi?id=203903
+
+        Reviewed by David Kilzer.
+
+        * BuildSlaveSupport/ews-app/ews/fetcher.py:
+        (BugzillaPatchFetcher.fetch):
+
 2019-11-06  Aakash Jain  <aakash_jain@apple.com>