Changeset 252198 in webkit

Timestamp:

Nov 7, 2019 11:59:31 AM (5 years ago)

Author:

Devin Rousso

Message:

Web Inspector: REGRESSION(r251958): automatic console prompt focusing prevents any "space" shortcuts from working
​https://bugs.webkit.org/show_bug.cgi?id=203939

Reviewed by Timothy Hatcher.

• UserInterface/Base/Main.js:

(WI.isShowingTimelineTab): Added.
(WI.isShowingAuditTab): Added.
(WI._restoreCookieForOpenTabs):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Base/Main.js (modified) (2 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2019-11-07  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: REGRESSION(r251958): automatic console prompt focusing prevents any "space" shortcuts from working
+        https://bugs.webkit.org/show_bug.cgi?id=203939
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Base/Main.js:
+        (WI.isShowingTimelineTab): Added.
+        (WI.isShowingAuditTab): Added.
+        (WI._restoreCookieForOpenTabs):
+
 2019-11-07  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Base/Main.js

@@ -1087 +1087 @@
 };
 
+WI.isShowingTimelineTab = function()
+{
+    return WI.tabBrowser.selectedTabContentView instanceof WI.TimelineTabContentView;
+};
+
+WI.isShowingAuditTab = function()
+{
+    return WI.tabBrowser.selectedTabContentView instanceof WI.AuditTabContentView;
+}
+
 WI.showLayersTab = function(options = {})
 {
@@ -1563 +1573 @@
 
     window.requestAnimationFrame(() => {
-        if (WI.isContentAreaFocused())
+        if (WI.isContentAreaFocused() || WI.isShowingTimelineTab() || WI.isShowingAuditTab())
             return;