Changeset 252201 in webkit
- Timestamp:
- Nov 7, 2019 12:31:44 PM (4 years ago)
- Location:
- trunk/Source/WebInspectorUI
- Files:
-
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebInspectorUI/ChangeLog
r252200 r252201 1 2019-11-07 Devin Rousso <drousso@apple.com> 2 3 Web Inspector: REGRESSION(r249451): missing "Reveal in DOM Tree" on nodes logged to the console 4 https://bugs.webkit.org/show_bug.cgi?id=203836 5 6 Reviewed by Timothy Hatcher. 7 8 * UserInterface/Views/ContextMenuUtilities.js: 9 (WI.appendContextMenuItemsForDOMNode): 10 * UserInterface/Views/DOMTreeOutline.js: 11 (WI.DOMTreeOutline.prototype.populateContextMenu): 12 DOM trees in the console are marked as being non-editable, which is intended to prevent 13 modifications (e.g. changing an attribute) from being made in the console as the DOM tree 14 there is not hooked up to the associated DOM agent. In r249451 however, this guard was over 15 expanded to include non-editing actions, like "Reveal in DOM Tree" and DOM breakpoints. 16 17 * UserInterface/Views/LogContentView.js: 18 (WI.LogContentView.prototype._handleContextMenuEvent): 19 Drive-by: add a separator before "Copy Selected" so it doesn't end up in the same group as 20 any "Collapse All" from a `WI.TreeOutline`. 21 1 22 2019-11-07 Devin Rousso <drousso@apple.com> 2 23 -
trunk/Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js
r252063 r252201 227 227 contextMenu.appendSeparator(); 228 228 229 if (!options. disallowEditing) {229 if (!options.usingLocalDOMNode) { 230 230 if (domNode.isCustomElement()) { 231 231 contextMenu.appendItem(WI.UIString("Jump to Definition"), () => { … … 261 261 } 262 262 263 if ( WI.cssManager.canForcePseudoClasses() && domNode.attached) {263 if (!options.disallowEditing && WI.cssManager.canForcePseudoClasses() && domNode.attached) { 264 264 contextMenu.appendSeparator(); 265 265 -
trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.js
r251302 r252201 296 296 let options = { 297 297 disallowEditing: !this._editable, 298 usingLocalDOMNode: this._usingLocalDOMNode, 298 299 excludeRevealElement: this._excludeRevealElementContextMenu, 299 300 copySubMenu: subMenus.copy, -
trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.js
r251227 r252201 507 507 let contextMenu = WI.ContextMenu.createFromEvent(event); 508 508 509 contextMenu.appendSeparator(); 510 509 511 if (this._selectedMessages.length) { 510 512 contextMenu.appendItem(WI.UIString("Copy Selected"), () => {
Note: See TracChangeset
for help on using the changeset viewer.