Changeset 252224 in webkit

Timestamp:

Nov 7, 2019 5:29:07 PM (4 years ago)

Author:

ysuzuki@apple.com

Message:

[bmalloc] Bug fix for wait time when it's in mini mode.
​https://bugs.webkit.org/show_bug.cgi?id=203121

Reviewed by Saam Barati.

Basuke pointed out that we never changed m_waitTime in scavenger when we are in iOS and mini-mode.
So previously, we are always executing scavenger for each 10ms in mini-mode. After fixing it, we
found that this unintentional behavior was better policy for RAMification.
In this patch, we explicitly use the old behavior, "scavenge for each 10ms" in iOS mini-mode.
We should revisit scavenger's behavior in the future to explore further better behavior.

• bmalloc/Scavenger.cpp:

(bmalloc::Scavenger::threadRunLoop):

Location:

trunk/Source/bmalloc

Files:

• ChangeLog (modified) (1 diff)
• bmalloc/Scavenger.cpp (modified) (1 diff)

trunk/Source/bmalloc/ChangeLog

@@ +1 @@
+2019-11-07  Basuke Suzuki  <Basuke.Suzuki@sony.com> and Yusuke Suzuki  <ysuzuki@apple.com>
+
+        [bmalloc] Bug fix for wait time when it's in mini mode.
+        https://bugs.webkit.org/show_bug.cgi?id=203121
+
+        Reviewed by Saam Barati.
+
+        Basuke pointed out that we never changed m_waitTime in scavenger when we are in iOS and mini-mode.
+        So previously, we are always executing scavenger for each 10ms in mini-mode. After fixing it, we
+        found that this unintentional behavior was better policy for RAMification.
+        In this patch, we explicitly use the old behavior, "scavenge for each 10ms" in iOS mini-mode.
+        We should revisit scavenger's behavior in the future to explore further better behavior.
+
+        * bmalloc/Scavenger.cpp:
+        (bmalloc::Scavenger::threadRunLoop):
+
 2019-11-06  Yusuke Suzuki  <ysuzuki@apple.com>
 

trunk/Source/bmalloc/bmalloc/Scavenger.cpp

@@ -496 +496 @@
         }
 
-        std::chrono::milliseconds newWaitTime;
-
-        if (m_isInMiniMode) {
-            timeSpentScavenging *= 50;
-            newWaitTime = std::chrono::duration_cast<std::chrono::milliseconds>(timeSpentScavenging);
-            newWaitTime = std::min(std::max(newWaitTime, std::chrono::milliseconds(25)), std::chrono::milliseconds(500));
-        } else {
+        // FIXME: We need to investigate mini-mode's adjustment.
+        // https://bugs.webkit.org/show_bug.cgi?id=203987
+        if (!m_isInMiniMode) {
             timeSpentScavenging *= 150;
-            newWaitTime = std::chrono::duration_cast<std::chrono::milliseconds>(timeSpentScavenging);
+            std::chrono::milliseconds newWaitTime = std::chrono::duration_cast<std::chrono::milliseconds>(timeSpentScavenging);
             m_waitTime = std::min(std::max(newWaitTime, std::chrono::milliseconds(100)), std::chrono::milliseconds(10000));
         }