Changeset 252242 in webkit

Timestamp:

Nov 8, 2019 10:24:23 AM (4 years ago)

Author:

Chris Dumez

Message:

Regression r252209: Layout Test fast/workers/worker-close-more.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=203995
<rdar://problem/57020558>

Reviewed by Ryosuke Niwa.

We should not dispatch events on a MessagePort objects in a WorkerGlobalScope which is
closing (i.e. WorkerGlobalScope.close() has been called).

No new tests, covered by fast/workers/worker-close-more.html.

• dom/MessagePort.cpp:

(WebCore::MessagePort::dispatchEvent):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/MessagePort.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-11-08  Chris Dumez  <cdumez@apple.com>
+
+        Regression r252209: Layout Test fast/workers/worker-close-more.html is failing
+        https://bugs.webkit.org/show_bug.cgi?id=203995
+        <rdar://problem/57020558>
+
+        Reviewed by Ryosuke Niwa.
+
+        We should not dispatch events on a MessagePort objects in a WorkerGlobalScope which is
+        closing (i.e. WorkerGlobalScope.close() has been called).
+
+        No new tests, covered by fast/workers/worker-close-more.html.
+
+        * dom/MessagePort.cpp:
+        (WebCore::MessagePort::dispatchEvent):
+
 2019-11-08  Peng Liu  <peng.liu6@apple.com>
 

trunk/Source/WebCore/dom/MessagePort.cpp

@@ -289 +289 @@
         return;
 
+    if (is<WorkerGlobalScope>(*m_scriptExecutionContext) && downcast<WorkerGlobalScope>(*m_scriptExecutionContext).isClosing())
+        return;
+
     EventTarget::dispatchEvent(event);
 }