Changeset 25234 in webkit


Ignore:
Timestamp:
Aug 25, 2007 5:21:02 AM (17 years ago)
Author:
bdash
Message:

2007-08-25 Mitz Pettel <​mitz@webkit.org>

Reviewed by Justin.

Test: editing/pasteboard/newlines-around-floating-or-positioned.html

  • editing/TextIterator.cpp: (WebCore::shouldEmitNewlinesBeforeAndAfterNode): Do not emit newlines around floating or positioned blocks. This behavior seems to match WinIE's.

2007-08-25 Mitz Pettel <​mitz@webkit.org>

Reviewed by Justin.

  • editing/pasteboard/newlines-around-floating-or-positioned-expected.txt: Added.
  • editing/pasteboard/newlines-around-floating-or-positioned.html: Added.
  • fast/events/capture-on-target-expected.txt:
  • fast/events/mouseclick-target-and-positioning-expected.txt:
  • fast/events/mouseover-mouseout-expected.txt:
  • fast/events/mouseover-mouseout2-expected.txt:
  • fast/events/window-events-bubble-expected.txt:
  • fast/events/window-events-bubble2-expected.txt:
  • fast/events/window-events-capture-expected.txt:
  • fast/forms/input-appearance-elementFromPoint-expected.txt:
  • fast/forms/onselect-textarea-expected.txt:
  • fast/forms/onselect-textfield-expected.txt:
Location:
trunk
Files:
2 added
13 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r25229 r25234  
     12007-08-25  Mitz Pettel  <mitz@webkit.org>
     2
     3        Reviewed by Justin.
     4
     5        - test and updated results for http://bugs.webkit.org/show_bug.cgi?id=14792
     6          <rdar://problem/5367763> REGRESSION: Copy inserts carriage return in middle of selection
     7
     8        * editing/pasteboard/newlines-around-floating-or-positioned-expected.txt: Added.
     9        * editing/pasteboard/newlines-around-floating-or-positioned.html: Added.
     10        * fast/events/capture-on-target-expected.txt:
     11        * fast/events/mouseclick-target-and-positioning-expected.txt:
     12        * fast/events/mouseover-mouseout-expected.txt:
     13        * fast/events/mouseover-mouseout2-expected.txt:
     14        * fast/events/window-events-bubble-expected.txt:
     15        * fast/events/window-events-bubble2-expected.txt:
     16        * fast/events/window-events-capture-expected.txt:
     17        * fast/forms/input-appearance-elementFromPoint-expected.txt:
     18        * fast/forms/onselect-textarea-expected.txt:
     19        * fast/forms/onselect-textfield-expected.txt:
     20
    1212007-08-24  Justin Garcia  <justin.garcia@apple.com>
    222

  • trunk/LayoutTests/fast/events/capture-on-target-expected.txt

    r17562 r25234  
    22
    33Click here
    4 
    54targetClickFired: true
    65containerClickFired: false

  • trunk/LayoutTests/fast/events/mouseclick-target-and-positioning-expected.txt

    r21687 r25234  
    11This page tests whether a click event propogates with the correct target and positioning. See rdar://problem/4477126.
    22
    3 click inside the red box:
    4 []
     3click inside the red box:[]
    54PASS: event target should be [object HTMLElement] and is
    65PASS: event.pageX should be 175 and is

  • trunk/LayoutTests/fast/events/mouseover-mouseout-expected.txt

    r21687 r25234  
    33Move the mouse pointer from left to right:
    44
    5 1              
    6 1              
    7 2
    8 3
    9 4
    10 5
    11 
     51               1               2345
    126Log     Expected results
    137mouseover on t1_1

  • trunk/LayoutTests/fast/events/mouseover-mouseout2-expected.txt

    r21687 r25234  
    33Move the mouse pointer from left to right:
    44
    5 
    6 3
    7 4
    8 
    9 5
    10 6
     53456
    116Log     Expected results
    127mouseover on frame1

  • trunk/LayoutTests/fast/events/window-events-bubble-expected.txt

    r17562 r25234  
    1 Test that stopPropagation() will not allow window events to bubble.
    2 Clicking on this should not fire window.onclick. This matches our old behavior and Firefox behavior.
    3 stopPropagation called. Test Passed.
    4 
     1Test that stopPropagation() will not allow window events to bubble. Clicking on this should not fire window.onclick. This matches our old behavior and Firefox behavior. stopPropagation called. Test Passed.

  • trunk/LayoutTests/fast/events/window-events-bubble2-expected.txt

    r17562 r25234  
    1 Tests that preventDefault() will still allow window events to bubble.
    2 Clicking here should fire window.onclick. This will match Firefox behavior.
    3 Window.onClick fired. Test Passed.
    4 
     1Tests that preventDefault() will still allow window events to bubble. Clicking here should fire window.onclick. This will match Firefox behavior. Window.onClick fired. Test Passed.

  • trunk/LayoutTests/fast/events/window-events-capture-expected.txt

    r12675 r25234  
    1 This tests that window events will fire in the capture phase.
    2 Click here
    3 
     1This tests that window events will fire in the capture phase. Click here
    42Capture: Window.onClick is called
    53stopPropagation called.

  • trunk/LayoutTests/fast/forms/input-appearance-elementFromPoint-expected.txt

    r16011 r25234  
    1 This tests that elementFromPoint will get the input element.
    2 Test Passed
    3 
     1This tests that elementFromPoint will get the input element. Test Passed

  • trunk/LayoutTests/fast/forms/onselect-textarea-expected.txt

    r18341 r25234  
    22This tests onSelect for textareas.
    33This also makes sure that the correct selection is restored when the element regains focus.
    4 
    54
    65Calling focus on textarea

  • trunk/LayoutTests/fast/forms/onselect-textfield-expected.txt

    r20072 r25234  
    11
    22This tests onSelect for text fields.
    3 
    43
    54Calling focus on text field

  • trunk/WebCore/ChangeLog

    r25229 r25234  
     12007-08-25  Mitz Pettel  <mitz@webkit.org>
     2
     3        Reviewed by Justin.
     4
     5        - fix http://bugs.webkit.org/show_bug.cgi?id=14792
     6          <rdar://problem/5367763> REGRESSION: Copy inserts carriage return in middle of selection
     7
     8        Test: editing/pasteboard/newlines-around-floating-or-positioned.html
     9
     10        * editing/TextIterator.cpp:
     11        (WebCore::shouldEmitNewlinesBeforeAndAfterNode): Do not emit newlines around
     12        floating or positioned blocks. This behavior seems to match WinIE's.
     13
    1142007-08-23  Justin Garcia  <justin.garcia@apple.com>
    215

  • trunk/WebCore/editing/TextIterator.cpp

    r24832 r25234  
    455455    }
    456456   
    457     return !r->isInline() && r->isRenderBlock() && !r->isBody();
     457    return !r->isInline() && r->isRenderBlock() && !r->isFloatingOrPositioned() && !r->isBody();
    458458}
    459459
Note: See TracChangeset for help on using the changeset viewer.