Changeset 25235 in webkit

Timestamp:

Aug 25, 2007 5:26:19 AM (17 years ago)

Author:

bdash

Message:

2007-08-25 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=14972 Moving cursor down in contentEditable section fails if styled line-height:1em

Test: editing/selection/move-by-line-003.html

• rendering/RenderText.cpp: (WebCore::RenderText::positionForCoordinates): Changed hit testing so that each line is tested for hits between its overflow top and the next line's overflow top. This matches RenderBlock::positionForCoordinates.

2007-08-25 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

• test for ​http://bugs.webkit.org/show_bug.cgi?id=14972 Moving cursor down in contentEditable section fails if styled line-height:1em

• editing/selection/move-by-line-003-expected.txt: Added.
• editing/selection/move-by-line-003.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/editing/selection/move-by-line-003-expected.txt (added)
• LayoutTests/editing/selection/move-by-line-003.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/rendering/RenderText.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2007-08-25  Mitz Pettel  <mitz@webkit.org>
+
+        Reviewed by Dave Hyatt.
+
+        - test for http://bugs.webkit.org/show_bug.cgi?id=14972
+          Moving cursor down in contentEditable section fails if styled line-height:1em
+
+        * editing/selection/move-by-line-003-expected.txt: Added.
+        * editing/selection/move-by-line-003.html: Added.
+
 2007-08-25  Mitz Pettel  <mitz@webkit.org>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2007-08-25  Mitz Pettel  <mitz@webkit.org>
+
+        Reviewed by Dave Hyatt.
+
+        - fix http://bugs.webkit.org/show_bug.cgi?id=14972
+          Moving cursor down in contentEditable section fails if styled line-height:1em
+
+        Test: editing/selection/move-by-line-003.html
+
+        * rendering/RenderText.cpp:
+        (WebCore::RenderText::positionForCoordinates): Changed hit testing so that each
+        line is tested for hits between its overflow top and the next line's overflow top.
+        This matches RenderBlock::positionForCoordinates.
+
 2007-08-25  Mitz Pettel  <mitz@webkit.org>
 

trunk/WebCore/rendering/RenderText.cpp

@@ -266 +266 @@
     for (InlineTextBox* box = firstTextBox(); box; box = box->nextTextBox()) {
         if (y >= box->root()->topOverflow()) {
-            if (y < box->root()->bottomOverflow()) {
+            int bottom = box->root()->nextRootBox() ? box->root()->nextRootBox()->topOverflow() : box->root()->bottomOverflow();
+            if (y < bottom) {
                 offset = box->offsetForPosition(x);