Changeset 252352 in webkit

Timestamp:

Nov 11, 2019 5:58:52 PM (4 years ago)

Author:

pvollan@apple.com

Message:

Many legacy animation tests are timing out with VS2019
​https://bugs.webkit.org/show_bug.cgi?id=204000

Reviewed by Brent Fulgham.

When compiling with VS2019, there is a compiler issue, where an Optional without a value is returned
when it should definitely have a value. Work around this issue by moving the local Optional value
when returning.

No new tests, covered by existing tests.

• page/animation/ImplicitAnimation.cpp:

(WebCore::ImplicitAnimation::timeToNextService):

• page/animation/KeyframeAnimation.cpp:

(WebCore::KeyframeAnimation::timeToNextService):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/animation/ImplicitAnimation.cpp (modified) (1 diff)
• page/animation/KeyframeAnimation.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-11-11  Per Arne Vollan  <pvollan@apple.com>
+
+        Many legacy animation tests are timing out with VS2019
+        https://bugs.webkit.org/show_bug.cgi?id=204000
+
+        Reviewed by Brent Fulgham.
+
+        When compiling with VS2019, there is a compiler issue, where an Optional without a value is returned
+        when it should definitely have a value. Work around this issue by moving the local Optional value
+        when returning.
+
+        No new tests, covered by existing tests.
+
+        * page/animation/ImplicitAnimation.cpp:
+        (WebCore::ImplicitAnimation::timeToNextService):
+        * page/animation/KeyframeAnimation.cpp:
+        (WebCore::KeyframeAnimation::timeToNextService):
+
 2019-11-11  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WebCore/page/animation/ImplicitAnimation.cpp

@@ -361 +361 @@
     Optional<Seconds> t = AnimationBase::timeToNextService();
     if (!t || t.value() != 0_s || preActive())
+#if COMPILER(MSVC) && _MSC_VER >= 1920
+        return WTFMove(t);
+#else
         return t;
+#endif
 
     // A return value of 0 means we need service. But if this is an accelerated animation we 

trunk/Source/WebCore/page/animation/KeyframeAnimation.cpp

@@ -516 +516 @@
     Optional<Seconds> t = AnimationBase::timeToNextService();
     if (!t || t.value() != 0_s || preActive())
+#if COMPILER(MSVC) && _MSC_VER >= 1920
+        return WTFMove(t);
+#else
         return t;
+#endif
 
     // A return value of 0 means we need service. But if we only have accelerated animations we