Changeset 252395 in webkit

Timestamp:

Nov 13, 2019 1:25:17 AM (5 years ago)

Author:

rniwa@webkit.org

Message:

Add punctuation rules for C++ lambdas
​https://bugs.webkit.org/show_bug.cgi?id=204021

Reviewed by Zalan Bujtas.

Added rules for not putting spaces between [] and () and omitting () whenever possible for C++ lambdas.

• code-style.md:

Location:

trunk/Websites/webkit.org

Files:

• ChangeLog (modified) (1 diff)
• code-style.md (modified) (2 diffs)

trunk/Websites/webkit.org/ChangeLog

@@ +1 @@
+2019-11-08  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Add punctuation rules for C++ lambdas
+        https://bugs.webkit.org/show_bug.cgi?id=204021
+
+        Reviewed by Zalan Bujtas.
+
+        Added rules for not putting spaces between [] and () and omitting () whenever possible for C++ lambdas.
+
+        * code-style.md:
+
 2019-10-26  Chris Lord  <clord@igalia.com>
 

trunk/Websites/webkit.org/code-style.md

@@ -235 +235 @@
 ```
 
+[](#spacing-lambda-paren) Do not place spaces between square brackets and parentheses of a lambda function but do place a space before braces.
+
+###### Right:
+
+```cpp
+[](int x) { return x; }
+[this] { return m_member; }
+```
+
+###### Wrong:
+
+```cpp
+[] (int x) { return x; }
+[this]{ return m_member; }
+```
+
 [](#spacing-braced-init) When initializing an object, place a space before the leading brace as well as between the braces and their content.
 
@@ -880 +896 @@
 for (Vector<RefPtr<FrameView> >::iterator it = frameViews.begin(); it != end; ++it)
     (*it)->updateLayoutAndStyleIfNeededRecursive();
+```
+
+[](#punctuation-omit-lambda-paren) Omit parentheses for a C++ lambda whenever possible.
+
+###### Right:
+
+```cpp
+[this] { return m_member; }
+[this]() mutable { return doWork(WTFMove(m_object)); }
+```
+
+###### Wrong:
+
+```cpp
+[this]() { return m_member; }
+[]() { return static_cast<unsigned>(-1); }
 ```