Changeset 252600 in webkit

Timestamp:

Nov 18, 2019 3:25:00 PM (4 years ago)

Author:

Chris Dumez

Message:

TestWebKitAPI.ProcessSwap.QuickBackForwardNavigationWithPSON is a flaky crash
​https://bugs.webkit.org/show_bug.cgi?id=199645
<rdar://problem/52856112>

Reviewed by Alex Christensen.

Make sure the test waits for the history navigations to complete before checking the
back/forward list.

• TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2019-11-18  Chris Dumez  <cdumez@apple.com>
+
+        TestWebKitAPI.ProcessSwap.QuickBackForwardNavigationWithPSON is a flaky crash
+        https://bugs.webkit.org/show_bug.cgi?id=199645
+        <rdar://problem/52856112>
+
+        Reviewed by Alex Christensen.
+
+        Make sure the test waits for the history navigations to complete before checking the
+        back/forward list.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
+
 2019-11-18  Keith Rollin  <krollin@apple.com>
 

trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm

@@ -2325 +2325 @@
     }
 
+    TestWebKitAPI::Util::run(&done);
+    done = false;
+
     Vector<String> backForwardListURLs;
     auto* backForwardList = [webView backForwardList];
@@ -2332 +2335 @@
     for (unsigned i = 0; i < backForwardList.forwardList.count; ++i)
         backForwardListURLs.append([backForwardList.forwardList[i].URL absoluteString]);
-    EXPECT_EQ(3u, backForwardListURLs.size());
+    RELEASE_ASSERT(backForwardListURLs.size() == 3u);
     EXPECT_WK_STREQ("pson://www.webkit.org/main1.html", backForwardListURLs[0]);
     EXPECT_WK_STREQ("pson://www.webkit.org/main2.html", backForwardListURLs[1]);