Changeset 252608 in webkit
- Timestamp:
- Nov 18, 2019 5:05:14 PM (4 years ago)
- Location:
- trunk/LayoutTests
- Files:
-
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r252598 r252608 1 2019-11-18 Megan Gardner <megan_gardner@apple.com> 2 3 Update dismiss-picker-using-keyboard.html test to work on iPad correctly 4 https://bugs.webkit.org/show_bug.cgi?id=204257 5 <rdar://problem/57239690> 6 7 Reviewed by Wenson Hsieh. 8 9 The iPad does not use the keyboard to show the options for these form controls, 10 and instead uses a popover. This expands the test infrastructure to allow for 11 either iPhone or iPad functionality. 12 13 * fast/forms/ios/dismiss-picker-using-keyboard.html: 14 * resources/ui-helper.js: 15 (window.UIHelper.activateAndWaitForInputSessionAt.return.new.Promise.): 16 (window.UIHelper.waitForInputSessionToDismiss.return.new.Promise.): 17 (window.UIHelper.waitForInputSessionToDismiss.return.new.Promise): 18 (window.UIHelper.waitForInputSessionToDismiss): 19 1 20 2019-11-18 Said Abou-Hallawa <sabouhallawa@apple.com> 2 21 -
trunk/LayoutTests/fast/forms/ios/dismiss-picker-using-keyboard.html
r243808 r252608 71 71 await UIHelper.activateElementAndWaitForInputSession(elementToTest); 72 72 UIHelper.keyDown(keyCommand.key, keyCommand.modifiers); 73 await UIHelper.waitFor KeyboardToHide();73 await UIHelper.waitForInputSessionToDismiss(); 74 74 shouldBeEqualToString("elementToTest.value", expectedValue); 75 75 } -
trunk/LayoutTests/resources/ui-helper.js
r252496 r252608 355 355 testRunner.runUIScript(` 356 356 (function() { 357 uiController.didShowKeyboardCallback = function() { 357 function clearCallbacksAndScriptComplete() { 358 uiController.didShowKeyboardCallback = null; 359 uiController.willPresentPopoverCallback = null; 358 360 uiController.uiScriptComplete(); 359 }; 361 } 362 uiController.didShowKeyboardCallback = clearCallbacksAndScriptComplete; 363 uiController.willPresentPopoverCallback = clearCallbacksAndScriptComplete; 360 364 uiController.singleTapAtPoint(${x}, ${y}, function() { }); 365 })()`, resolve); 366 }); 367 } 368 369 static waitForInputSessionToDismiss() 370 { 371 return new Promise(resolve => { 372 testRunner.runUIScript(` 373 (function() { 374 function clearCallbacksAndScriptComplete() { 375 uiController.didHideKeyboardCallback = null; 376 uiController.didDismissPopoverCallback = null; 377 uiController.uiScriptComplete(); 378 } 379 uiController.didHideKeyboardCallback = clearCallbacksAndScriptComplete; 380 uiController.didDismissPopoverCallback = clearCallbacksAndScriptComplete; 361 381 })()`, resolve); 362 382 });
Note: See TracChangeset
for help on using the changeset viewer.