Changeset 252700 in webkit

Timestamp:

Nov 20, 2019, 12:14:25 PM (6 years ago)

Author:

Jonathan Bedard

Message:

[EWS] iOS layout-tests fails with 30+ failures on re-run and on clean-tree
​https://bugs.webkit.org/show_bug.cgi?id=204409

Reviewed by Aakash Jain.

• BuildSlaveSupport/ews-build/steps.py:

(RunWebKitPerlTests.evaluateCommand): Add killOldProcesses before running test suite.
(RunJavaScriptCoreTests.evaluateCommand): Ditto.
(ReRunJavaScriptCoreTests.evaluateCommand): Ditto.
(RunWebKitTests.evaluateCommand): Ditto.
(ReRunWebKitTests.evaluateCommand): Ditto.
(RunAPITests.evaluateCommand): Ditto.
(ReRunAPITests.evaluateCommand): Ditto.

Location:

trunk/Tools

Files:

• BuildSlaveSupport/ews-build/steps.py (modified) (7 diffs)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/ews-build/steps.py ¶

@@ -633 +633 @@
         rc = shell.ShellCommand.evaluateCommand(self, cmd)
         if rc == FAILURE:
-            self.build.addStepsAfterCurrentStep([ReRunWebKitPerlTests()])
+            self.build.addStepsAfterCurrentStep([KillOldProcesses(), ReRunWebKitPerlTests()])
         return rc
 
@@ -975 +975 @@
             self.build.buildFinished([message], SUCCESS)
         else:
-            self.build.addStepsAfterCurrentStep([ValidatePatch(verifyBugClosed=False, addURLs=False), ReRunJavaScriptCoreTests()])
+            self.build.addStepsAfterCurrentStep([ValidatePatch(verifyBugClosed=False, addURLs=False), KillOldProcesses(), ReRunJavaScriptCoreTests()])
         return rc
 
@@ -1051 +1051 @@
                                                 CompileJSCToT(),
                                                 ValidatePatch(verifyBugClosed=False, addURLs=False),
+                                                KillOldProcesses(),
                                                 RunJSCTestsWithoutPatch(),
                                                 AnalyzeJSCTestsResults()])
@@ -1289 +1290 @@
             self.build.buildFinished([message], SUCCESS)
         else:
-            self.build.addStepsAfterCurrentStep([ArchiveTestResults(), UploadTestResults(), ExtractTestResults(), ValidatePatch(verifyBugClosed=False, addURLs=False), ReRunWebKitTests()])
+            self.build.addStepsAfterCurrentStep([
+                ArchiveTestResults(),
+                UploadTestResults(),
+                ExtractTestResults(),
+                ValidatePatch(verifyBugClosed=False, addURLs=False),
+                KillOldProcesses(),
+                ReRunWebKitTests(),
+            ])
         return rc
 
@@ -1321 +1329 @@
                                                 CompileWebKitToT(),
                                                 ValidatePatch(verifyBugClosed=False, addURLs=False),
+                                                KillOldProcesses(),
                                                 RunWebKitTestsWithoutPatch()])
         return rc
@@ -1627 +1636 @@
             self.build.buildFinished([message], SUCCESS)
         else:
-            self.build.addStepsAfterCurrentStep([ValidatePatch(verifyBugClosed=False, addURLs=False), ReRunAPITests()])
+            self.build.addStepsAfterCurrentStep([ValidatePatch(verifyBugClosed=False, addURLs=False), KillOldProcesses(), ReRunAPITests()])
         return rc
 
@@ -1647 +1656 @@
                                                 CompileWebKitToT(),
                                                 ValidatePatch(verifyBugClosed=False, addURLs=False),
+                                                KillOldProcesses(),
                                                 RunAPITestsWithoutPatch(),
                                                 AnalyzeAPITestsResults()])

trunk/Tools/ChangeLog ¶

@@ +1 @@
+2019-11-20  Jonathan Bedard  <jbedard@apple.com>
+
+        [EWS] iOS layout-tests fails with 30+ failures on re-run and on clean-tree
+        https://bugs.webkit.org/show_bug.cgi?id=204409
+
+        Reviewed by Aakash Jain.
+
+        * BuildSlaveSupport/ews-build/steps.py:
+        (RunWebKitPerlTests.evaluateCommand): Add killOldProcesses before running test suite.
+        (RunJavaScriptCoreTests.evaluateCommand): Ditto.
+        (ReRunJavaScriptCoreTests.evaluateCommand): Ditto.
+        (RunWebKitTests.evaluateCommand): Ditto.
+        (ReRunWebKitTests.evaluateCommand): Ditto.
+        (RunAPITests.evaluateCommand): Ditto.
+        (ReRunAPITests.evaluateCommand): Ditto.
+
 2019-11-20  Jonathan Bedard  <jbedard@apple.com>