Changeset 252749 in webkit


Ignore:
Timestamp:
Nov 21, 2019 1:30:10 PM (4 years ago)
Author:
Simon Fraser
Message:

Flaky Test: compositing/backing/backing-store-attachment-with-rotation.html
​https://bugs.webkit.org/show_bug.cgi?id=204394

Reviewed by Myles C. Maxfield.

Move compositing-overlap-utils.js to compositing/resources and use its layerTreeWithoutTransforms()
function to not dump transforms for the flakey test.

Adjust other tests which use this JS file.

  • compositing/backing/backing-store-attachment-with-rotation-expected.txt:
  • compositing/backing/backing-store-attachment-with-rotation.html:
  • compositing/layer-creation/animation-overlap-with-children.html:
  • compositing/layer-creation/mismatched-rotated-transform-animation-overlap.html:
  • compositing/layer-creation/mismatched-rotated-transform-transition-overlap.html:
  • compositing/layer-creation/mismatched-transform-transition-overlap.html:
  • compositing/layer-creation/multiple-keyframes-animation-overlap.html:
  • compositing/layer-creation/scale-rotation-animation-overlap.html:
  • compositing/layer-creation/scale-rotation-transition-overlap.html:
  • compositing/layer-creation/translate-animation-overlap.html:
  • compositing/layer-creation/translate-scale-animation-overlap.html:
  • compositing/layer-creation/translate-scale-transition-overlap.html:
  • compositing/layer-creation/translate-transition-overlap.html:
  • compositing/resources/compositing-test-utils.js: Renamed from LayoutTests/compositing/layer-creation/resources/compositing-overlap-utils.js.

(makeDots):
(layerTreeWithoutTransforms):
(dumpLayersWithoutTransforms):

  • legacy-animation-engine/compositing/layer-creation/animation-overlap-with-children.html:
  • legacy-animation-engine/compositing/layer-creation/mismatched-rotated-transform-animation-overlap.html:
  • legacy-animation-engine/compositing/layer-creation/mismatched-rotated-transform-transition-overlap.html:
  • legacy-animation-engine/compositing/layer-creation/mismatched-transform-transition-overlap.html:
  • legacy-animation-engine/compositing/layer-creation/multiple-keyframes-animation-overlap.html:
  • legacy-animation-engine/compositing/layer-creation/scale-rotation-animation-overlap.html:
  • legacy-animation-engine/compositing/layer-creation/scale-rotation-transition-overlap.html:
  • legacy-animation-engine/compositing/layer-creation/translate-animation-overlap.html:
  • legacy-animation-engine/compositing/layer-creation/translate-scale-animation-overlap.html:
  • legacy-animation-engine/compositing/layer-creation/translate-scale-transition-overlap.html:
  • legacy-animation-engine/compositing/layer-creation/translate-transition-overlap.html:
Location:
trunk/LayoutTests
Files:
25 edited
1 moved

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r252747 r252749  
     12019-11-21  Simon Fraser  <simon.fraser@apple.com>
     2
     3        Flaky Test: compositing/backing/backing-store-attachment-with-rotation.html
     4        https://bugs.webkit.org/show_bug.cgi?id=204394
     5
     6        Reviewed by Myles C. Maxfield.
     7
     8        Move compositing-overlap-utils.js to compositing/resources and use its layerTreeWithoutTransforms()
     9        function to not dump transforms for the flakey test.
     10
     11        Adjust other tests which use this JS file.
     12
     13        * compositing/backing/backing-store-attachment-with-rotation-expected.txt:
     14        * compositing/backing/backing-store-attachment-with-rotation.html:
     15        * compositing/layer-creation/animation-overlap-with-children.html:
     16        * compositing/layer-creation/mismatched-rotated-transform-animation-overlap.html:
     17        * compositing/layer-creation/mismatched-rotated-transform-transition-overlap.html:
     18        * compositing/layer-creation/mismatched-transform-transition-overlap.html:
     19        * compositing/layer-creation/multiple-keyframes-animation-overlap.html:
     20        * compositing/layer-creation/scale-rotation-animation-overlap.html:
     21        * compositing/layer-creation/scale-rotation-transition-overlap.html:
     22        * compositing/layer-creation/translate-animation-overlap.html:
     23        * compositing/layer-creation/translate-scale-animation-overlap.html:
     24        * compositing/layer-creation/translate-scale-transition-overlap.html:
     25        * compositing/layer-creation/translate-transition-overlap.html:
     26        * compositing/resources/compositing-test-utils.js: Renamed from LayoutTests/compositing/layer-creation/resources/compositing-overlap-utils.js.
     27        (makeDots):
     28        (layerTreeWithoutTransforms):
     29        (dumpLayersWithoutTransforms):
     30        * legacy-animation-engine/compositing/layer-creation/animation-overlap-with-children.html:
     31        * legacy-animation-engine/compositing/layer-creation/mismatched-rotated-transform-animation-overlap.html:
     32        * legacy-animation-engine/compositing/layer-creation/mismatched-rotated-transform-transition-overlap.html:
     33        * legacy-animation-engine/compositing/layer-creation/mismatched-transform-transition-overlap.html:
     34        * legacy-animation-engine/compositing/layer-creation/multiple-keyframes-animation-overlap.html:
     35        * legacy-animation-engine/compositing/layer-creation/scale-rotation-animation-overlap.html:
     36        * legacy-animation-engine/compositing/layer-creation/scale-rotation-transition-overlap.html:
     37        * legacy-animation-engine/compositing/layer-creation/translate-animation-overlap.html:
     38        * legacy-animation-engine/compositing/layer-creation/translate-scale-animation-overlap.html:
     39        * legacy-animation-engine/compositing/layer-creation/translate-scale-transition-overlap.html:
     40        * legacy-animation-engine/compositing/layer-creation/translate-transition-overlap.html:
     41
    1422019-11-21  Nikita Vasilyev  <nvasilyev@apple.com>
    243

  • trunk/LayoutTests/compositing/backing/backing-store-attachment-with-rotation-expected.txt

    r252486 r252749  
    1616          (drawsContent 1)
    1717          (backingStoreAttached 1)
    18           (transform [-0.00 1.00 0.00 0.00] [-1.00 -0.00 0.00 0.00] [0.00 0.00 1.00 0.00] [0.00 0.00 0.00 1.00])
    1918        )
    2019      )

  • trunk/LayoutTests/compositing/backing/backing-store-attachment-with-rotation.html

    r252486 r252749  
    3131        }
    3232    </style>
     33    <script src="../resources/compositing-test-utils.js"></script>
    3334    <script>
    3435        if (window.testRunner) {
    … …  
    4142            var layersResult = document.getElementById('layers');
    4243            if (window.testRunner)
    43                 layersResult.innerText = window.internals.layerTreeAsText(document, internals.LAYER_TREE_INCLUDES_BACKING_STORE_ATTACHED);
     44                layersResult.innerText = layerTreeWithoutTransforms(internals.LAYER_TREE_INCLUDES_BACKING_STORE_ATTACHED);
    4445        }
    4546

  • trunk/LayoutTests/compositing/layer-creation/animation-overlap-with-children.html

    r244800 r252749  
    5353    }
    5454  </style>
    55   <script src="resources/compositing-overlap-utils.js"></script>
     55  <script src="../resources/compositing-test-utils.js"></script>
    5656  <script>
    5757    if (window.testRunner) {
    … …  
    6363    {
    6464      var box = document.getElementById('to-animate');
    65       box.addEventListener('webkitAnimationStart', dumpLayers, false);
     65      box.addEventListener('webkitAnimationStart', dumpLayersWithoutTransforms, false);
    6666      box.classList.add('animating');
    6767    }

  • trunk/LayoutTests/compositing/layer-creation/mismatched-rotated-transform-animation-overlap.html

    r244800 r252749  
    3838        }
    3939    </style>
    40     <script src="resources/compositing-overlap-utils.js"></script>
     40  <script src="../resources/compositing-test-utils.js"></script>
    4141    <script>
    4242        if (window.testRunner) {
    … …  
    5050           
    5151            window.setTimeout(function() {
    52                 document.getElementById('target').addEventListener('animationstart', dumpLayers, false);
     52                document.getElementById('target').addEventListener('animationstart', dumpLayersWithoutTransforms, false);
    5353                document.body.classList.add('changed');
    5454            }, 0);

  • trunk/LayoutTests/compositing/layer-creation/mismatched-rotated-transform-transition-overlap.html

    r244800 r252749  
    2929        }
    3030    </style>
    31     <script src="resources/compositing-overlap-utils.js"></script>
     31    <script src="../resources/compositing-test-utils.js"></script>
    3232    <script>
    3333        if (window.testRunner) {
    … …  
    4242            window.setTimeout(function() {
    4343                document.body.classList.add('changed');
    44                 window.setTimeout(dumpLayers, 0);
     44                window.setTimeout(dumpLayersWithoutTransforms, 0);
    4545            }, 0);
    4646        }

  • trunk/LayoutTests/compositing/layer-creation/mismatched-transform-transition-overlap.html

    r244800 r252749  
    2929        }
    3030    </style>
    31     <script src="resources/compositing-overlap-utils.js"></script>
     31    <script src="../resources/compositing-test-utils.js"></script>
    3232    <script>
    3333        if (window.testRunner) {
    … …  
    4242            window.setTimeout(function() {
    4343                document.body.classList.add('changed');
    44                 window.setTimeout(dumpLayers, 0);
     44                window.setTimeout(dumpLayersWithoutTransforms, 0);
    4545            }, 0);
    4646        }

  • trunk/LayoutTests/compositing/layer-creation/multiple-keyframes-animation-overlap.html

    r244800 r252749  
    4646        }
    4747    </style>
    48     <script src="resources/compositing-overlap-utils.js"></script>
     48    <script src="../resources/compositing-test-utils.js"></script>
    4949    <script>
    5050        if (window.testRunner) {
    … …  
    5858           
    5959            window.setTimeout(function() {
    60                 document.getElementById('target').addEventListener('animationstart', dumpLayers, false);
     60                document.getElementById('target').addEventListener('animationstart', dumpLayersWithoutTransforms, false);
    6161                document.body.classList.add('changed');
    6262            }, 0);

  • trunk/LayoutTests/compositing/layer-creation/scale-rotation-animation-overlap.html

    r244800 r252749  
    4646        }
    4747    </style>
    48     <script src="resources/compositing-overlap-utils.js"></script>
     48    <script src="../resources/compositing-test-utils.js"></script>
    4949    <script>
    5050        if (window.testRunner) {
    … …  
    5858           
    5959            window.setTimeout(function() {
    60                 document.getElementById('target').addEventListener('animationstart', dumpLayers, false);
     60                document.getElementById('target').addEventListener('animationstart', dumpLayersWithoutTransforms, false);
    6161                document.body.classList.add('changed');
    6262            }, 0);

  • trunk/LayoutTests/compositing/layer-creation/scale-rotation-transition-overlap.html

    r244800 r252749  
    2828        }
    2929    </style>
    30     <script src="resources/compositing-overlap-utils.js"></script>
     30    <script src="../resources/compositing-test-utils.js"></script>
    3131    <script>
    3232        if (window.testRunner) {

  • trunk/LayoutTests/compositing/layer-creation/translate-animation-overlap.html

    r244800 r252749  
    3535        }
    3636    </style>
    37     <script src="resources/compositing-overlap-utils.js"></script>
     37    <script src="../resources/compositing-test-utils.js"></script>
    3838    <script>
    3939        if (window.testRunner) {
    … …  
    4747           
    4848            window.setTimeout(function() {
    49                 document.getElementById('target').addEventListener('animationstart', dumpLayers, false);
     49                document.getElementById('target').addEventListener('animationstart', dumpLayersWithoutTransforms, false);
    5050                document.body.classList.add('changed');
    5151            }, 0);

  • trunk/LayoutTests/compositing/layer-creation/translate-scale-animation-overlap.html

    r244800 r252749  
    3737        }
    3838    </style>
    39     <script src="resources/compositing-overlap-utils.js"></script>
     39    <script src="../resources/compositing-test-utils.js"></script>
    4040    <script>
    4141        if (window.testRunner) {
    … …  
    4949           
    5050            window.setTimeout(function() {
    51                 document.getElementById('target').addEventListener('animationstart', dumpLayers, false);
     51                document.getElementById('target').addEventListener('animationstart', dumpLayersWithoutTransforms, false);
    5252                document.body.classList.add('changed');
    5353            }, 0);

  • trunk/LayoutTests/compositing/layer-creation/translate-scale-transition-overlap.html

    r244800 r252749  
    2828        }
    2929    </style>
    30     <script src="resources/compositing-overlap-utils.js"></script>
     30    <script src="../resources/compositing-test-utils.js"></script>
    3131    <script>
    3232        if (window.testRunner) {

  • trunk/LayoutTests/compositing/layer-creation/translate-transition-overlap.html

    r244800 r252749  
    2828        }
    2929    </style>
    30     <script src="resources/compositing-overlap-utils.js"></script>
     30    <script src="../resources/compositing-test-utils.js"></script>
    3131    <script>
    3232        if (window.testRunner) {
    … …  
    4141            window.setTimeout(function() {
    4242                document.body.classList.add('changed');
    43                 window.setTimeout(dumpLayers, 0);
     43                window.setTimeout(dumpLayersWithoutTransforms, 0);
    4444            }, 0);
    4545        }

  • trunk/LayoutTests/compositing/resources/compositing-test-utils.js

    r252748 r252749  
    1212}
    1313
    14 function layerTreeWithoutTransforms()
     14function layerTreeWithoutTransforms(layerTreeFlags = 0)
    1515{
    16     var layerTreeText = internals.layerTreeAsText(document);
     16    var layerTreeText = internals.layerTreeAsText(document, layerTreeFlags);
    1717    var filteredLines = layerTreeText.split("\n").filter(line => line.indexOf('transform') == -1);
    1818    return filteredLines.join('\n');
    1919}
    2020
    21 function dumpLayers()
     21function dumpLayersWithoutTransforms()
    2222{
    2323    if (window.testRunner) {

  • trunk/LayoutTests/legacy-animation-engine/compositing/layer-creation/animation-overlap-with-children.html

    r244800 r252749  
    5353    }
    5454  </style>
    55   <script src="../../../compositing/layer-creation/resources/compositing-overlap-utils.js"></script>
     55  <script src="../../../compositing/resources/compositing-test-utils.js"></script>
    5656  <script>
    5757    if (window.testRunner) {
    … …  
    6363    {
    6464      var box = document.getElementById('to-animate');
    65       box.addEventListener('webkitAnimationStart', dumpLayers, false);
     65      box.addEventListener('webkitAnimationStart', dumpLayersWithoutTransforms, false);
    6666      box.classList.add('animating');
    6767    }

  • trunk/LayoutTests/legacy-animation-engine/compositing/layer-creation/mismatched-rotated-transform-animation-overlap.html

    r244800 r252749  
    3838        }
    3939    </style>
    40     <script src="../../../compositing/layer-creation/resources/compositing-overlap-utils.js"></script>
     40    <script src="../../../compositing/resources/compositing-test-utils.js"></script>
    4141    <script>
    4242        if (window.testRunner) {
    … …  
    5050           
    5151            window.setTimeout(function() {
    52                 document.getElementById('target').addEventListener('animationstart', dumpLayers, false);
     52                document.getElementById('target').addEventListener('animationstart', dumpLayersWithoutTransforms, false);
    5353                document.body.classList.add('changed');
    5454            }, 0);

  • trunk/LayoutTests/legacy-animation-engine/compositing/layer-creation/mismatched-rotated-transform-transition-overlap.html

    r244800 r252749  
    2929        }
    3030    </style>
    31     <script src="../../../compositing/layer-creation/resources/compositing-overlap-utils.js"></script>
     31    <script src="../../../compositing/resources/compositing-test-utils.js"></script>
    3232    <script>
    3333        if (window.testRunner) {
    … …  
    4242            window.setTimeout(function() {
    4343                document.body.classList.add('changed');
    44                 window.setTimeout(dumpLayers, 0);
     44                window.setTimeout(dumpLayersWithoutTransforms, 0);
    4545            }, 0);
    4646        }

  • trunk/LayoutTests/legacy-animation-engine/compositing/layer-creation/mismatched-transform-transition-overlap.html

    r244800 r252749  
    2929        }
    3030    </style>
    31     <script src="../../../compositing/layer-creation/resources/compositing-overlap-utils.js"></script>
     31    <script src="../../../compositing/resources/compositing-test-utils.js"></script>
    3232    <script>
    3333        if (window.testRunner) {
    … …  
    4242            window.setTimeout(function() {
    4343                document.body.classList.add('changed');
    44                 window.setTimeout(dumpLayers, 0);
     44                window.setTimeout(dumpLayersWithoutTransforms, 0);
    4545            }, 0);
    4646        }

  • trunk/LayoutTests/legacy-animation-engine/compositing/layer-creation/multiple-keyframes-animation-overlap.html

    r244800 r252749  
    4646        }
    4747    </style>
    48     <script src="../../../compositing/layer-creation/resources/compositing-overlap-utils.js"></script>
     48    <script src="../../../compositing/resources/compositing-test-utils.js"></script>
    4949    <script>
    5050        if (window.testRunner) {
    … …  
    5858
    5959            window.setTimeout(function() {
    60                 document.getElementById('target').addEventListener('animationstart', dumpLayers, false);
     60                document.getElementById('target').addEventListener('animationstart', dumpLayersWithoutTransforms, false);
    6161                document.body.classList.add('changed');
    6262            }, 0);

  • trunk/LayoutTests/legacy-animation-engine/compositing/layer-creation/scale-rotation-animation-overlap.html

    r244800 r252749  
    4646        }
    4747    </style>
    48     <script src="../../../compositing/layer-creation/resources/compositing-overlap-utils.js"></script>
     48    <script src="../../../compositing/resources/compositing-test-utils.js"></script>
    4949    <script>
    5050        if (window.testRunner) {
    … …  
    5858           
    5959            window.setTimeout(function() {
    60                 document.getElementById('target').addEventListener('animationstart', dumpLayers, false);
     60                document.getElementById('target').addEventListener('animationstart', dumpLayersWithoutTransforms, false);
    6161                document.body.classList.add('changed');
    6262            }, 0);

  • trunk/LayoutTests/legacy-animation-engine/compositing/layer-creation/scale-rotation-transition-overlap.html

    r244800 r252749  
    2828        }
    2929    </style>
    30     <script src="../../../compositing/layer-creation/resources/compositing-overlap-utils.js"></script>
     30    <script src="../../../compositing/resources/compositing-test-utils.js"></script>
    3131    <script>
    3232        if (window.testRunner) {
    … …  
    4141            window.setTimeout(function() {
    4242                document.body.classList.add('changed');
    43                 window.setTimeout(dumpLayers, 0);
     43                window.setTimeout(dumpLayersWithoutTransforms, 0);
    4444            }, 0);
    4545        }

  • trunk/LayoutTests/legacy-animation-engine/compositing/layer-creation/translate-animation-overlap.html

    r244800 r252749  
    3535        }
    3636    </style>
    37     <script src="../../../compositing/layer-creation/resources/compositing-overlap-utils.js"></script>
     37    <script src="../../../compositing/resources/compositing-test-utils.js"></script>
    3838    <script>
    3939        if (window.testRunner) {
    … …  
    4747
    4848            window.setTimeout(function() {
    49                 document.getElementById('target').addEventListener('animationstart', dumpLayers, false);
     49                document.getElementById('target').addEventListener('animationstart', dumpLayersWithoutTransforms, false);
    5050                document.body.classList.add('changed');
    5151            }, 0);

  • trunk/LayoutTests/legacy-animation-engine/compositing/layer-creation/translate-scale-animation-overlap.html

    r244800 r252749  
    3737        }
    3838    </style>
    39     <script src="../../../compositing/layer-creation/resources/compositing-overlap-utils.js"></script>
     39    <script src="../../../compositing/resources/compositing-test-utils.js"></script>
    4040    <script>
    4141        if (window.testRunner) {
    … …  
    4949           
    5050            window.setTimeout(function() {
    51                 document.getElementById('target').addEventListener('animationstart', dumpLayers, false);
     51                document.getElementById('target').addEventListener('animationstart', dumpLayersWithoutTransforms, false);
    5252                document.body.classList.add('changed');
    5353            }, 0);

  • trunk/LayoutTests/legacy-animation-engine/compositing/layer-creation/translate-scale-transition-overlap.html

    r244800 r252749  
    2828        }
    2929    </style>
    30     <script src="../../../compositing/layer-creation/resources/compositing-overlap-utils.js"></script>
     30    <script src="../../../compositing/resources/compositing-test-utils.js"></script>
    3131    <script>
    3232        if (window.testRunner) {
    … …  
    4141            window.setTimeout(function() {
    4242                document.body.classList.add('changed');
    43                 window.setTimeout(dumpLayers, 0);
     43                window.setTimeout(dumpLayersWithoutTransforms, 0);
    4444            }, 0);
    4545        }

  • trunk/LayoutTests/legacy-animation-engine/compositing/layer-creation/translate-transition-overlap.html

    r244800 r252749  
    2828        }
    2929    </style>
    30     <script src="../../../compositing/layer-creation/resources/compositing-overlap-utils.js"></script>
     30    <script src="../../../compositing/resources/compositing-test-utils.js"></script>
    3131    <script>
    3232        if (window.testRunner) {
    … …  
    4141            window.setTimeout(function() {
    4242                document.body.classList.add('changed');
    43                 window.setTimeout(dumpLayers, 0);
     43                window.setTimeout(dumpLayersWithoutTransforms, 0);
    4444            }, 0);
    4545        }
Note: See TracChangeset for help on using the changeset viewer.