Changeset 252926 in webkit

Timestamp:

Nov 28, 2019, 8:03:35 AM (6 years ago)

Author:

aakash_jain@apple.com

Message:

Removed ENABLED_QUEUES logic from ews-app
​https://bugs.webkit.org/show_bug.cgi?id=204683

Unreviewed minor fix.

• BuildSlaveSupport/ews-app/ews/views/statusbubble.py:

(StatusBubble): Removed ENABLED_QUEUES.
(StatusBubble._build_bubbles_for_patch):
(StatusBubble._should_show_bubble_for_queue): Deleted.

Location:

trunk/Tools

Files:

• BuildSlaveSupport/ews-app/ews/views/statusbubble.py (modified) (3 diffs)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py

@@ -42 +42 @@
     ALL_QUEUES = ['style', 'ios', 'ios-sim', 'mac', 'mac-debug', 'gtk', 'wpe', 'wincairo', 'win',
                   'ios-wk2', 'mac-wk1', 'mac-wk2', 'mac-debug-wk1', 'api-ios', 'api-mac', 'bindings', 'jsc', 'jsc-armv7', 'jsc-mips', 'webkitperl', 'webkitpy', 'services']
-    ENABLED_QUEUES = ['style', 'ios', 'ios-sim', 'mac', 'mac-debug', 'gtk', 'wpe', 'wincairo', 'win',
-                      'ios-wk2', 'mac-wk1', 'mac-wk2', 'mac-debug-wk1', 'api-ios', 'api-mac', 'bindings', 'jsc', 'jsc-armv7', 'jsc-mips', 'webkitperl', 'webkitpy', 'services']
     # FIXME: Auto-generate the queue's trigger relationship
     QUEUE_TRIGGERS = {
@@ -250 +248 @@
         return True
 
-    def _should_show_bubble_for_queue(self, queue):
-        return queue in StatusBubble.ENABLED_QUEUES
-
     def _queue_position(self, patch, queue, parent_queue=None):
         # FIXME: Handle retried builds and cancelled build-requests as well.
@@ -291 +286 @@
 
         for queue in StatusBubble.ALL_QUEUES:
-            if not self._should_show_bubble_for_queue(queue):
-                continue
-
             bubble = self._build_bubble(patch, queue, hide_icons)
             if bubble:

trunk/Tools/ChangeLog

@@ +1 @@
+2019-11-28  Aakash Jain  <aakash_jain@apple.com>
+
+        Removed ENABLED_QUEUES logic from ews-app
+        https://bugs.webkit.org/show_bug.cgi?id=204683
+
+        Unreviewed minor fix.
+
+        * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
+        (StatusBubble): Removed ENABLED_QUEUES.
+        (StatusBubble._build_bubbles_for_patch):
+        (StatusBubble._should_show_bubble_for_queue): Deleted.
+
 2019-11-28  Aakash Jain  <aakash_jain@apple.com>