Changeset 253312 in webkit


Ignore:
Timestamp:
Dec 9, 2019, 5:48:58 PM (5 years ago)
Author:
Patrick Griffis
Message:

Import secure cookie tests from WPT
​https://bugs.webkit.org/show_bug.cgi?id=204193

Reviewed by Carlos Alberto Lopez Perez.

LayoutTests/imported/w3c:

  • resources/import-expectations.json:
  • web-platform-tests/cookies/resources/cookie-helper.sub.js: Added.

(credFetch):
(assert_dom_cookie):
(assert_cookie):
(resetSameSiteCookies):
(resetSecureCookies):

  • web-platform-tests/cookies/resources/drop.py: Added.

(main):

  • web-platform-tests/cookies/resources/dropSameSite.py: Added.

(main):

  • web-platform-tests/cookies/resources/dropSecure.py: Added.

(main):

  • web-platform-tests/cookies/resources/echo-cookie.html: Added.
  • web-platform-tests/cookies/resources/echo-json.py: Added.

(main):

  • web-platform-tests/cookies/resources/helpers.py: Added.

(setNoCacheAndCORSHeaders):
(makeCookieHeader):
(makeCookieHeader.makeAV):
(makeDropCookie):
(readParameter):
(readCookies):

  • web-platform-tests/cookies/resources/imgIfMatch.py: Added.

(main):

  • web-platform-tests/cookies/resources/list.py: Added.

(main):

  • web-platform-tests/cookies/resources/postToParent.py: Added.

(main):

  • web-platform-tests/cookies/resources/redirectWithCORSHeaders.py: Added.

(main):

  • web-platform-tests/cookies/resources/set-cookie.py: Added.

(main):

  • web-platform-tests/cookies/resources/set.py: Added.

(main):

  • web-platform-tests/cookies/resources/setSameSite.py: Added.

(main):

  • web-platform-tests/cookies/resources/setSecure.py: Added.

(main):

  • web-platform-tests/cookies/resources/testharness-helpers.js: Added.

(executeNextTest):
(executeTestsSerially):

  • web-platform-tests/cookies/secure/set-from-dom.https.sub-expected.txt: Added.
  • web-platform-tests/cookies/secure/set-from-dom.https.sub.html: Added.
  • web-platform-tests/cookies/secure/set-from-dom.sub-expected.txt: Added.
  • web-platform-tests/cookies/secure/set-from-dom.sub.html: Added.
  • web-platform-tests/cookies/secure/set-from-http.https.sub-expected.txt: Added.
  • web-platform-tests/cookies/secure/set-from-http.https.sub.html: Added.
  • web-platform-tests/cookies/secure/set-from-http.https.sub.html.headers: Added.
  • web-platform-tests/cookies/secure/set-from-http.sub-expected.txt: Added.
  • web-platform-tests/cookies/secure/set-from-http.sub.html: Added.
  • web-platform-tests/cookies/secure/set-from-http.sub.html.headers: Added.
  • web-platform-tests/cookies/secure/set-from-ws.sub-expected.txt: Added.
  • web-platform-tests/cookies/secure/set-from-ws.sub.html: Added.
  • web-platform-tests/cookies/secure/set-from-wss.https.sub-expected.txt: Added.
  • web-platform-tests/cookies/secure/set-from-wss.https.sub.html: Added.

LayoutTests:

Mark newly imported test as failing.
Pending fix for WPE/GTK in webkit.org/b/169356

  • platform/gtk/TestExpectations:
  • platform/mac-wk1/TestExpectations:
  • platform/wpe/TestExpectations:
  • platform/ios-wk2/imported/w3c/web-platform-tests/content-security-policy/reporting/report-same-origin-with-cookies-expected.txt: Added.
Location:
trunk/LayoutTests
Files:
35 added
7 edited
1 copied

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r253310 r253312  
     12019-12-09  Patrick Griffis  <pgriffis@igalia.com>
     2
     3        Import secure cookie tests from WPT
     4        https://bugs.webkit.org/show_bug.cgi?id=204193
     5
     6        Reviewed by Carlos Alberto Lopez Perez.
     7
     8        Mark newly imported test as failing.
     9        Pending fix for WPE/GTK in webkit.org/b/169356
     10
     11        * platform/gtk/TestExpectations:
     12        * platform/mac-wk1/TestExpectations:
     13        * platform/wpe/TestExpectations:
     14        * platform/ios-wk2/imported/w3c/web-platform-tests/content-security-policy/reporting/report-same-origin-with-cookies-expected.txt: Added.
     15
    1162019-12-09  Megan Gardner  <megan_gardner@apple.com>
    217

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r253297 r253312  
     12019-12-09  Patrick Griffis  <pgriffis@igalia.com>
     2
     3        Import secure cookie tests from WPT
     4        https://bugs.webkit.org/show_bug.cgi?id=204193
     5
     6        Reviewed by Carlos Alberto Lopez Perez.
     7
     8        * resources/import-expectations.json:
     9        * web-platform-tests/cookies/resources/cookie-helper.sub.js: Added.
     10        (credFetch):
     11        (assert_dom_cookie):
     12        (assert_cookie):
     13        (resetSameSiteCookies):
     14        (resetSecureCookies):
     15        * web-platform-tests/cookies/resources/drop.py: Added.
     16        (main):
     17        * web-platform-tests/cookies/resources/dropSameSite.py: Added.
     18        (main):
     19        * web-platform-tests/cookies/resources/dropSecure.py: Added.
     20        (main):
     21        * web-platform-tests/cookies/resources/echo-cookie.html: Added.
     22        * web-platform-tests/cookies/resources/echo-json.py: Added.
     23        (main):
     24        * web-platform-tests/cookies/resources/helpers.py: Added.
     25        (setNoCacheAndCORSHeaders):
     26        (makeCookieHeader):
     27        (makeCookieHeader.makeAV):
     28        (makeDropCookie):
     29        (readParameter):
     30        (readCookies):
     31        * web-platform-tests/cookies/resources/imgIfMatch.py: Added.
     32        (main):
     33        * web-platform-tests/cookies/resources/list.py: Added.
     34        (main):
     35        * web-platform-tests/cookies/resources/postToParent.py: Added.
     36        (main):
     37        * web-platform-tests/cookies/resources/redirectWithCORSHeaders.py: Added.
     38        (main):
     39        * web-platform-tests/cookies/resources/set-cookie.py: Added.
     40        (main):
     41        * web-platform-tests/cookies/resources/set.py: Added.
     42        (main):
     43        * web-platform-tests/cookies/resources/setSameSite.py: Added.
     44        (main):
     45        * web-platform-tests/cookies/resources/setSecure.py: Added.
     46        (main):
     47        * web-platform-tests/cookies/resources/testharness-helpers.js: Added.
     48        (executeNextTest):
     49        (executeTestsSerially):
     50        * web-platform-tests/cookies/secure/set-from-dom.https.sub-expected.txt: Added.
     51        * web-platform-tests/cookies/secure/set-from-dom.https.sub.html: Added.
     52        * web-platform-tests/cookies/secure/set-from-dom.sub-expected.txt: Added.
     53        * web-platform-tests/cookies/secure/set-from-dom.sub.html: Added.
     54        * web-platform-tests/cookies/secure/set-from-http.https.sub-expected.txt: Added.
     55        * web-platform-tests/cookies/secure/set-from-http.https.sub.html: Added.
     56        * web-platform-tests/cookies/secure/set-from-http.https.sub.html.headers: Added.
     57        * web-platform-tests/cookies/secure/set-from-http.sub-expected.txt: Added.
     58        * web-platform-tests/cookies/secure/set-from-http.sub.html: Added.
     59        * web-platform-tests/cookies/secure/set-from-http.sub.html.headers: Added.
     60        * web-platform-tests/cookies/secure/set-from-ws.sub-expected.txt: Added.
     61        * web-platform-tests/cookies/secure/set-from-ws.sub.html: Added.
     62        * web-platform-tests/cookies/secure/set-from-wss.https.sub-expected.txt: Added.
     63        * web-platform-tests/cookies/secure/set-from-wss.https.sub.html: Added.
     64
    1652019-12-09  youenn fablet  <youenn@apple.com>
    266

  • trunk/LayoutTests/imported/w3c/resources/import-expectations.json

    r253067 r253312  
    5858    "web-platform-tests/content-security-policy": "import",
    5959    "web-platform-tests/cookies": "skip",
     60    "web-platform-tests/cookies/resources": "import",
     61    "web-platform-tests/cookies/secure": "import",
    6062    "web-platform-tests/core-aam": "skip",
    6163    "web-platform-tests/cors": "import",

  • trunk/LayoutTests/imported/w3c/web-platform-tests/content-security-policy/reporting/report-same-origin-with-cookies-expected.txt

    r246330 r253312  
    33PASS Image should not load
    44PASS Violation report status OK.
    5 FAIL Test report cookies. assert_true: Report should contain cookie: cspViolationReportCookie2 expected true got false
     5PASS Test report cookies.
    66

  • trunk/LayoutTests/platform/gtk/TestExpectations

    r252919 r253312  
    39553955webkit.org/b/204675 imported/w3c/web-platform-tests/offscreen-canvas/filter/offscreencanvas.filter.w.html [ Missing ]
    39563956
     3957webkit.org/b/169356 imported/w3c/web-platform-tests/cookies/secure/set-from-dom.sub.html [ Failure ]
     3958
    39573959#////////////////////////////////////////////////////////////////////////////////////////
    39583960# End of non-crashing, non-flaky tests failing

  • trunk/LayoutTests/platform/mac-wk1/TestExpectations

    r252769 r253312  
    396396storage/indexeddb/modern/exceed-open-file-limit.html
    397397
     398# Only fails in WK1
     399imported/w3c/web-platform-tests/cookies/secure/set-from-wss.https.sub.html [ Failure ]
     400imported/w3c/web-platform-tests/cookies/secure/set-from-ws.sub.html [ Failure ]
     401
    398402### END OF (2) Failures without bug reports
    399403########################################

  • trunk/LayoutTests/platform/wpe/TestExpectations

    r253035 r253312  
    498498webkit.org/b/200165 imported/w3c/web-platform-tests/websockets/cookies/007.html [ Failure ]
    499499webkit.org/b/200165 imported/w3c/web-platform-tests/websockets/cookies/004.html [ Failure ]
     500
     501webkit.org/b/169356 imported/w3c/web-platform-tests/cookies/secure/set-from-dom.sub.html [ Failure ]
    500502
    501503#////////////////////////////////////////////////////////////////////////////////////////
Note: See TracChangeset for help on using the changeset viewer.