Changeset 253908 in webkit

Timestamp:

Dec 25, 2019 5:09:04 AM (4 years ago)

Author:

Wenson Hsieh

Message:

REGRESSION (r253282): Tests that use applyAutocorrection assert in UIScriptContext::requestUIScriptCompletion
​https://bugs.webkit.org/show_bug.cgi?id=205588
<rdar://problem/58109942>

Reviewed by Tim Horton.

The change made in r253282 intended to defer completing the async task prepared in
UIScriptController::applyAutocorrection until after the current runloop; however, it ended up keeping the
synchronous call to asyncTaskComplete. Fix this by removing this code, so that we instead wait for the
dispatch_async block to invoke asyncTaskComplete.

• WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptControllerIOS::applyAutocorrection):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• WebKitTestRunner/ios/UIScriptControllerIOS.mm (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2019-12-25  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        REGRESSION (r253282): Tests that use applyAutocorrection assert in UIScriptContext::requestUIScriptCompletion
+        https://bugs.webkit.org/show_bug.cgi?id=205588
+        <rdar://problem/58109942>
+
+        Reviewed by Tim Horton.
+
+        The change made in r253282 intended to defer completing the async task prepared in
+        UIScriptController::applyAutocorrection until after the current runloop; however, it ended up keeping the
+        synchronous call to asyncTaskComplete. Fix this by removing this code, so that we instead wait for the
+        dispatch_async block to invoke asyncTaskComplete.
+
+        * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
+        (WTR::UIScriptControllerIOS::applyAutocorrection):
+
 2019-12-24  Youenn Fablet  <youenn@apple.com>
 

trunk/Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm

@@ -666 +666 @@
             m_context->asyncTaskComplete(callbackID);
         }).get());
-        if (!m_context)
-            return;
-        m_context->asyncTaskComplete(callbackID);
     }).get()];
 }