Changeset 254364 in webkit


Ignore:
Timestamp:
Jan 10, 2020 1:38:08 PM (4 years ago)
Author:
Brent Fulgham
Message:

[iOS] Remove 'com.apple.cookied' from the WebContent process sandbox
​https://bugs.webkit.org/show_bug.cgi?id=206083
<rdar://problem/56963865>

Reviewed by Per Arne Vollan.

Telemetry and testing have confirmed that we no longer use the 'com.apple.cookied' mach connection
in the WebContent process on iOS. We should remove this from the WebContent process sandbox

Source/WebKit:

Tested by fast/sandbox/ios/sandbox-mach-lookup.html.

  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

LayoutTests:

  • fast/sandbox/ios/sandbox-mach-lookup-expected.txt:
  • fast/sandbox/ios/sandbox-mach-lookup.html:
Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r254363 r254364  
     12020-01-10  Brent Fulgham  <bfulgham@apple.com>
     2
     3        [iOS] Remove 'com.apple.cookied' from the WebContent process sandbox
     4        https://bugs.webkit.org/show_bug.cgi?id=206083
     5        <rdar://problem/56963865>
     6
     7        Reviewed by Per Arne Vollan.
     8
     9        Telemetry and testing have confirmed that we no longer use the 'com.apple.cookied' mach connection
     10        in the WebContent process on iOS. We should remove this from the WebContent process sandbox
     11
     12        * fast/sandbox/ios/sandbox-mach-lookup-expected.txt:
     13        * fast/sandbox/ios/sandbox-mach-lookup.html:
     14
    1152020-01-10  Brent Fulgham  <bfulgham@apple.com>
    216

  • trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup-expected.txt

    r254363 r254364  
    77PASS internals.hasSandboxMachLookupAccessToXPCServiceName("com.apple.WebKit.WebContent", "com.apple.viewservice") is false
    88PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.TextInput") is false
     9PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.cookied") is false
    910PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.locationd.registration") is false
    1011PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.nehelper") is false

  • trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup.html

    r254363 r254364  
    1010    shouldBeFalse("internals.hasSandboxMachLookupAccessToXPCServiceName(\"com.apple.WebKit.WebContent\", \"com.apple.viewservice\")");
    1111    shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.TextInput\")");
     12    shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.cookied\")");
    1213    shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.locationd.registration\")");
    1314    shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.nehelper\")");

  • trunk/Source/WebKit/ChangeLog

    r254363 r254364  
     12020-01-10  Brent Fulgham  <bfulgham@apple.com>
     2
     3        [iOS] Remove 'com.apple.cookied' from the WebContent process sandbox
     4        https://bugs.webkit.org/show_bug.cgi?id=206083
     5        <rdar://problem/56963865>
     6
     7        Reviewed by Per Arne Vollan.
     8
     9        Telemetry and testing have confirmed that we no longer use the 'com.apple.cookied' mach connection
     10        in the WebContent process on iOS. We should remove this from the WebContent process sandbox
     11
     12        Tested by fast/sandbox/ios/sandbox-mach-lookup.html.
     13
     14        * Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
     15
    1162020-01-10  Brent Fulgham  <bfulgham@apple.com>
    217

  • trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb

    r254363 r254364  
    940940
    941941(allow mach-lookup (with report) (with telemetry)
    942     (global-name "com.apple.cookied")
    943942    (global-name "com.apple.PowerManagement.control"))
    944943
Note: See TracChangeset for help on using the changeset viewer.