Changeset 254407 in webkit

Timestamp:

Jan 11, 2020 4:49:34 PM (4 years ago)

Author:

Alan Bujtas

Message:

[LFC] isOkToAccessDisplayBox should return false on formatting context root access.
​https://bugs.webkit.org/show_bug.cgi?id=206123
<rdar://problem/58500267>

Reviewed by Antti Koivisto.

From now on any geometry access outside of the formatting context without a valid reason is considered an escape.

• layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::geometryForBox const):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• layout/FormattingContext.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-01-11  Zalan Bujtas  <zalan@apple.com>
+
+        [LFC] isOkToAccessDisplayBox should return false on formatting context root access.
+        https://bugs.webkit.org/show_bug.cgi?id=206123
+        <rdar://problem/58500267>
+
+        Reviewed by Antti Koivisto.
+
+        From now on any geometry access outside of the formatting context without a valid reason is considered an escape.
+
+        * layout/FormattingContext.cpp:
+        (WebCore::Layout::FormattingContext::geometryForBox const):
+
 2020-01-11  Noam Rosenthal  <noam@webkit.org>
 

trunk/Source/WebCore/layout/FormattingContext.cpp

@@ -222 +222 @@
         }
 
-        if (&layoutBox == &root()) {
-            // FIXME: This is formatting context escaping in the strict sense, since the formatting context root box lives in the parent formatting context.
-            // This happens e.g. when a block level box box needs to stretch horizontally and checks its containing block for horizontal space (this should probably be limited to reading horizontal constraint values).
-            return true;
-        }
-
         if (!escapeReason) {
-            // At this point any access is considered an escape.
+            // Any geometry access outside of the formatting context without a valid reason is considered an escape.
             return false;
         }