Changeset 254427 in webkit

Timestamp:

Jan 13, 2020, 3:54:07 AM (6 years ago)

Author:

Antti Koivisto

Message:

[LFC][Integration] imported/blink/fast/shapes/crash-caused-by-dirtying-a-shape-while-computing-it-requires-a-long-filename-to-crash.html crashes on iOS
​https://bugs.webkit.org/show_bug.cgi?id=206151

Reviewed by Zalan Bujtas.

• layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::TreeBuilder::createLayoutBox):

LFC doesn't expect line break boxes with float set (other layout systems just ignore it).

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• layout/layouttree/LayoutTreeBuilder.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-01-13  Antti Koivisto  <antti@apple.com>
+
+        [LFC][Integration] imported/blink/fast/shapes/crash-caused-by-dirtying-a-shape-while-computing-it-requires-a-long-filename-to-crash.html crashes on iOS
+        https://bugs.webkit.org/show_bug.cgi?id=206151
+
+        Reviewed by Zalan Bujtas.
+
+        * layout/layouttree/LayoutTreeBuilder.cpp:
+        (WebCore::Layout::TreeBuilder::createLayoutBox):
+
+        LFC doesn't expect line break boxes with float set (other layout systems just ignore it).
+
 2020-01-13  Antti Koivisto  <antti@apple.com>
 

trunk/Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp

@@ -196 +196 @@
         if (is<RenderLineBreak>(renderer)) {
             clonedStyle.setDisplay(DisplayType::Inline);
+            clonedStyle.setFloating(Float::No);
             childLayoutBox = makeUnique<Box>(elementAttributes(renderer), WTFMove(clonedStyle));
         } else if (is<RenderTable>(renderer)) {