Changeset 254472 in webkit

Timestamp:

Jan 13, 2020 4:39:43 PM (4 years ago)

Author:

Kate Cheney

Message:

_WKResourceLoadStatisticsFirstParty should be forward declared not imported in _WKResourceLoadStatisticsThirdParty
​https://bugs.webkit.org/show_bug.cgi?id=206183
<rdar://problem/58535245>

Reviewed by Alex Christensen.

• UIProcess/API/Cocoa/_WKResourceLoadStatisticsFirstParty.h:
• UIProcess/API/Cocoa/_WKResourceLoadStatisticsThirdParty.h:
• UIProcess/API/Cocoa/_WKResourceLoadStatisticsThirdParty.mm:

The additional import statement here was unnecessary because
this file imports _WKResourceLoadStatisticsThirdPartyInternal.h
which forward declares the _WKResourceLoadStatisticsFirstParty class.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/Cocoa/_WKResourceLoadStatisticsFirstParty.h (modified) (1 diff)
• UIProcess/API/Cocoa/_WKResourceLoadStatisticsThirdParty.h (modified) (1 diff)
• UIProcess/API/Cocoa/_WKResourceLoadStatisticsThirdParty.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-01-13  Kate Cheney  <katherine_cheney@apple.com>
+
+        _WKResourceLoadStatisticsFirstParty should be forward declared not imported in _WKResourceLoadStatisticsThirdParty
+        https://bugs.webkit.org/show_bug.cgi?id=206183
+        <rdar://problem/58535245>
+
+        Reviewed by Alex Christensen.
+
+        * UIProcess/API/Cocoa/_WKResourceLoadStatisticsFirstParty.h:
+        * UIProcess/API/Cocoa/_WKResourceLoadStatisticsThirdParty.h:
+        * UIProcess/API/Cocoa/_WKResourceLoadStatisticsThirdParty.mm:
+        The additional import statement here was unnecessary because
+        this file imports _WKResourceLoadStatisticsThirdPartyInternal.h
+        which forward declares the _WKResourceLoadStatisticsFirstParty class.
+
 2020-01-13  Kate Cheney  <katherine_cheney@apple.com>
 

trunk/Source/WebKit/UIProcess/API/Cocoa/_WKResourceLoadStatisticsFirstParty.h

@@ -24 +24 @@
  */
 
+#import <WebKit/WKFoundation.h>
+
 NS_ASSUME_NONNULL_BEGIN
 

trunk/Source/WebKit/UIProcess/API/Cocoa/_WKResourceLoadStatisticsThirdParty.h

@@ -24 +24 @@
  */
 
-#import "_WKResourceLoadStatisticsFirstParty.h"
+#import <WebKit/WKFoundation.h>
 
 NS_ASSUME_NONNULL_BEGIN
+
+@class _WKResourceLoadStatisticsFirstParty;
 
 WK_CLASS_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA))

trunk/Source/WebKit/UIProcess/API/Cocoa/_WKResourceLoadStatisticsThirdParty.mm

@@ -28 +28 @@
 
 #import "APIArray.h"
-#import "_WKResourceLoadStatisticsFirstParty.h"
 
 @implementation _WKResourceLoadStatisticsThirdParty