Changeset 254492 in webkit

Timestamp:

Jan 13, 2020 9:40:51 PM (4 years ago)

Author:

Simon Fraser

Message:

Scrollbar hiding on iOS via ::-webkit-scrollbar { display: none } doesn't work
​https://bugs.webkit.org/show_bug.cgi?id=206197

Reviewed by Tim Horton.
Source/WebCore:

The logic added in r251369 was reversed, causing scrollbar hiding to not work correctly.

Tested by fast/scrolling/ios/scrollbar-hiding.html

• rendering/RenderScrollbar.cpp:

(WebCore::RenderScrollbar::isHiddenByStyle const):

LayoutTests:

The logic added in r251369 was reversed, causing scrollbar hiding to not work correctly.

• fast/scrolling/ios/scrollbar-hiding-expected.txt:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/scrolling/ios/scrollbar-hiding-expected.txt (modified) (2 diffs)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderScrollbar.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2020-01-13  Simon Fraser  <simon.fraser@apple.com>
+
+        Scrollbar hiding on iOS via ::-webkit-scrollbar { display: none } doesn't work
+        https://bugs.webkit.org/show_bug.cgi?id=206197
+
+        Reviewed by Tim Horton.
+        
+        The logic added in r251369 was reversed, causing scrollbar hiding to not work correctly.
+
+        * fast/scrolling/ios/scrollbar-hiding-expected.txt:
+
 2020-01-13  Pablo Saavedra  <psaavedra@igalia.com>
 

trunk/LayoutTests/fast/scrolling/ios/scrollbar-hiding-expected.txt

@@ -36 +36 @@
         (vertical scrollbar mode 0)
         (has enabled horizontal scrollbar 1)
+        (has enabled vertical scrollbar 1)))
+    (overflow scrolling node
+      (scrollable area size width=200 height=100)
+      (total content size width=400 height=200)
+      (last committed scroll position (0,0))
+      (scrollable area parameters 
+        (horizontal scroll elasticity 1)
+        (vertical scroll elasticity 1)
+        (horizontal scrollbar mode 0)
+        (vertical scrollbar mode 0)
+        (has enabled horizontal scrollbar 1)
         (has enabled vertical scrollbar 1)
-        (horizontal scrollbar hidden by style 1)
         (vertical scrollbar hidden by style 1)))
     (overflow scrolling node
@@ -62 +72 @@
         (has enabled horizontal scrollbar 1)
         (has enabled vertical scrollbar 1)
-        (vertical scrollbar hidden by style 1)))
-    (overflow scrolling node
-      (scrollable area size width=200 height=100)
-      (total content size width=400 height=200)
-      (last committed scroll position (0,0))
-      (scrollable area parameters 
-        (horizontal scroll elasticity 1)
-        (vertical scroll elasticity 1)
-        (horizontal scrollbar mode 0)
-        (vertical scrollbar mode 0)
-        (has enabled horizontal scrollbar 1)
-        (has enabled vertical scrollbar 1)))))
+        (horizontal scrollbar hidden by style 1)
+        (vertical scrollbar hidden by style 1)))))

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-01-13  Simon Fraser  <simon.fraser@apple.com>
+
+        Scrollbar hiding on iOS via ::-webkit-scrollbar { display: none } doesn't work
+        https://bugs.webkit.org/show_bug.cgi?id=206197
+
+        Reviewed by Tim Horton.
+
+        The logic added in r251369 was reversed, causing scrollbar hiding to not work correctly.
+        
+        Tested by fast/scrolling/ios/scrollbar-hiding.html
+
+        * rendering/RenderScrollbar.cpp:
+        (WebCore::RenderScrollbar::isHiddenByStyle const):
+
 2020-01-13  Jer Noble  <jer.noble@apple.com>
 

trunk/Source/WebCore/rendering/RenderScrollbar.cpp

@@ -364 +364 @@
 {
     std::unique_ptr<RenderStyle> partStyle = getScrollbarPseudoStyle(ScrollbarBGPart, pseudoForScrollbarPart(ScrollbarBGPart));
-    return partStyle && partStyle->display() != DisplayType::None;
-}
-
-}
+    return partStyle && partStyle->display() == DisplayType::None;
+}
+
+}