Changeset 255157 in webkit

Timestamp:

Jan 27, 2020 11:33:06 AM (4 years ago)

Author:

aakash_jain@apple.com

Message:

[ews] Status bubble hover over message in case of success should indicate whether it built the patch or run tests
​https://bugs.webkit.org/show_bug.cgi?id=206807

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/ews-app/ews/views/statusbubble.py:

Location:

trunk/Tools

Files:

• BuildSlaveSupport/ews-app/ews/views/statusbubble.py (modified) (2 diffs)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py

@@ -66 +66 @@
             'name': queue,
         }
+        is_tester_queue = self._is_tester_queue(queue)
+        is_builder_queue = self._is_builder_queue(queue)
         if hide_icons == False:
-            if self._is_tester_queue(queue):
+            if is_tester_queue:
                 bubble['name'] = StatusBubble.TESTER_ICON + '  ' + bubble['name']
-            if self._is_builder_queue(queue):
+            if is_builder_queue:
                 bubble['name'] = StatusBubble.BUILDER_ICON + '  ' + bubble['name']
 
@@ -111 +113 @@
             else:
                 bubble['state'] = 'pass'
-                bubble['details_message'] = 'Pass'
+                if is_builder_queue and is_tester_queue:
+                    bubble['details_message'] = 'Built successfully and passed tests'
+                elif is_builder_queue:
+                    bubble['details_message'] = 'Built successfully'
+                elif is_tester_queue:
+                    if queue == 'style':
+                        bubble['details_message'] = 'Passed style check'
+                    else:
+                        bubble['details_message'] = 'Passed tests'
+                else:
+                    bubble['details_message'] = 'Pass'
         elif build.result == Buildbot.WARNINGS:
             bubble['state'] = 'pass'

trunk/Tools/ChangeLog

@@ +1 @@
+2020-01-26  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews] Status bubble hover over message in case of success should indicate whether it built the patch or run tests
+        https://bugs.webkit.org/show_bug.cgi?id=206807
+
+        Reviewed by Jonathan Bedard.
+
+        * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
+
 2020-01-27  Kate Cheney  <katherine_cheney@apple.com>