Changeset 255273 in webkit

Timestamp:

Jan 28, 2020 1:20:26 PM (4 years ago)

Author:

don.olmstead@sony.com

Message:

[LFC][Integration] Build and enable on Windows
​https://bugs.webkit.org/show_bug.cgi?id=206165

Reviewed by Darin Adler.

.:

Enable LFC for Windows.

• Source/cmake/OptionsWin.cmake:

Source/WebCore:

Fix minor compilation issues in LFC when using MSVC.

• layout/inlineformatting/LineLayoutContext.cpp:

(WebCore::Layout::LineLayoutContext::close):

Location:

trunk

Files:

• ChangeLog (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/layout/inlineformatting/LineLayoutContext.cpp (modified) (1 diff)
• Source/cmake/OptionsWin.cmake (modified) (1 diff)

trunk/ChangeLog

@@ +1 @@
+2020-01-28  Don Olmstead  <don.olmstead@sony.com>
+
+        [LFC][Integration] Build and enable on Windows
+        https://bugs.webkit.org/show_bug.cgi?id=206165
+
+        Reviewed by Darin Adler.
+
+        Enable LFC for Windows.
+
+        * Source/cmake/OptionsWin.cmake:
+
 2020-01-24  Sergio Villar Senin  <svillar@igalia.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-01-28  Don Olmstead  <don.olmstead@sony.com>
+
+        [LFC][Integration] Build and enable on Windows
+        https://bugs.webkit.org/show_bug.cgi?id=206165
+
+        Reviewed by Darin Adler.
+
+        Fix minor compilation issues in LFC when using MSVC.
+
+        * layout/inlineformatting/LineLayoutContext.cpp:
+        (WebCore::Layout::LineLayoutContext::close):
+
 2020-01-28  Brent Fulgham  <bfulgham@apple.com>
 

trunk/Source/WebCore/layout/inlineformatting/LineLayoutContext.cpp

@@ -317 +317 @@
         m_successiveHyphenatedLineCount = 0;
 
-    auto trailingInlineItemIndex = layoutRange.start + committedInlineItemCount - 1;
+    unsigned trailingInlineItemIndex = layoutRange.start + committedInlineItemCount - 1;
     ASSERT(trailingInlineItemIndex < layoutRange.end);
     auto isLastLineWithInlineContent = [&] {

trunk/Source/cmake/OptionsWin.cmake

@@ -85 +85 @@
     WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_TYPED_OM PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
     WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_FILTERS_LEVEL_2 PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
+    WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_LAYOUT_FORMATTING_CONTEXT PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
     WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_REMOTE_INSPECTOR PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
     WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_RESOURCE_LOAD_STATISTICS PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})