Changeset 255364 in webkit

Timestamp:

Jan 29, 2020 10:01:14 AM (4 years ago)

Author:

Andres Gonzalez

Message:

Crash in AXIsolatedObject destruction.
​https://bugs.webkit.org/show_bug.cgi?id=206828

Reviewed by Carlos Alberto Lopez Perez.

Fix for crash on GTK introduced with this IsolatedTree change.

• accessibility/atk/AccessibilityObjectAtk.cpp:

(WebCore::AccessibilityObject::detachPlatformWrapper):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• accessibility/atk/AccessibilityObjectAtk.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-01-29  Andres Gonzalez  <andresg_22@apple.com>
+
+        Crash in AXIsolatedObject destruction.
+        https://bugs.webkit.org/show_bug.cgi?id=206828
+
+        Reviewed by Carlos Alberto Lopez Perez.
+
+        Fix for crash on GTK introduced with this IsolatedTree change.
+
+        * accessibility/atk/AccessibilityObjectAtk.cpp:
+        (WebCore::AccessibilityObject::detachPlatformWrapper):
+
 2020-01-29  Peng Liu  <peng.liu6@apple.com>
 

trunk/Source/WebCore/accessibility/atk/AccessibilityObjectAtk.cpp

@@ -38 +38 @@
 void AccessibilityObject::detachPlatformWrapper(AccessibilityDetachmentType detachmentType)
 {
-    if (auto* cache = axObjectCache())
-        cache->detachWrapper(this, detachmentType);
+    if (detachmentType != AccessibilityDetachmentType::CacheDestroyed) {
+        if (auto* cache = axObjectCache())
+            cache->detachWrapper(this, detachmentType);
+    }
+
+    auto* wrapper = this->wrapper();
+    ASSERT(wrapper);
+    webkitAccessibleDetach(WEBKIT_ACCESSIBLE(wrapper));
 }