Changeset 255431 in webkit

Timestamp:

Jan 30, 2020 9:35:20 AM (4 years ago)

Author:

Chris Dumez

Message:

REGRESSION (r252064): [ Mac iOS ] storage/websql/statement-error-callback.html is timing out flakily
​https://bugs.webkit.org/show_bug.cgi?id=206291
<rdar://problem/58606666>

Unreviewed, partial rollout of r252064 which seems to have introduced the regression.

No new tests, covered by existing test

• Modules/webdatabase/SQLTransaction.cpp:

(WebCore::SQLTransaction::notifyDatabaseThreadIsShuttingDown):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/webdatabase/SQLTransaction.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-01-30  Chris Dumez  <cdumez@apple.com>
+
+        REGRESSION (r252064): [ Mac iOS ] storage/websql/statement-error-callback.html is timing out flakily
+        https://bugs.webkit.org/show_bug.cgi?id=206291
+        <rdar://problem/58606666>
+
+        Unreviewed, partial rollout of r252064 which seems to have introduced the regression.
+
+        No new tests, covered by existing test
+
+        * Modules/webdatabase/SQLTransaction.cpp:
+        (WebCore::SQLTransaction::notifyDatabaseThreadIsShuttingDown):
+
 2020-01-30  Joonghun Park  <jh718.park@samsung.com>
 

trunk/Source/WebCore/Modules/webdatabase/SQLTransaction.cpp

@@ -128 +128 @@
 void SQLTransaction::notifyDatabaseThreadIsShuttingDown()
 {
-    callOnMainThread([this, protectedThis = makeRef(*this)]() mutable {
-        callErrorCallbackDueToInterruption();
-    });
-
     m_backend.notifyDatabaseThreadIsShuttingDown();
 }