Changeset 256030 in webkit

Timestamp:

Feb 7, 2020 10:10:04 AM (4 years ago)

Author:

youenn@apple.com

Message:

Mandate UUID version 4 for mDNS ICE candidates
​https://bugs.webkit.org/show_bug.cgi?id=207329
<rdar://problem/59221606>

Address post-commit comments from Darin by using isASCIIHexDigit.

Unreviewed.

• wtf/UUID.cpp:

(WTF::isVersion4UUID):
(WTF::isHexadecimalCharacter): Deleted.

Location:

trunk/Source/WTF

Files:

• ChangeLog (modified) (1 diff)
• wtf/UUID.cpp (modified) (3 diffs)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2020-02-07  youenn fablet  <youenn@apple.com>
+
+        Mandate UUID version 4 for mDNS ICE candidates
+        https://bugs.webkit.org/show_bug.cgi?id=207329
+        <rdar://problem/59221606>
+
+        Address post-commit comments from Darin by using isASCIIHexDigit.
+
+        Unreviewed.
+
+        * wtf/UUID.cpp:
+        (WTF::isVersion4UUID):
+        (WTF::isHexadecimalCharacter): Deleted.
+
 2020-02-07  youenn fablet  <youenn@apple.com>
 

trunk/Source/WTF/wtf/UUID.cpp

@@ -33 +33 @@
 
 #include <mutex>
+#include <wtf/ASCIICType.h>
 #include <wtf/CryptographicallyRandomNumber.h>
 #include <wtf/HexNumber.h>
@@ -82 +83 @@
 }
 
-static inline bool isHexadecimalCharacter(UChar character)
-{
-    return (character >= '0' && character <= '9')
-        || (character >= 'a' && character <= 'f')
-        || (character >= 'A' && character <= 'F');
-}
-
 bool isVersion4UUID(StringView value)
 {
@@ -112 +106 @@
             continue;
         }
-        if (!isHexadecimalCharacter(value[cptr]))
+        if (!isASCIIHexDigit(value[cptr]))
             return false;
     }