Changeset 256452 in webkit
- Timestamp:
- Feb 12, 2020 10:46:31 AM (4 years ago)
- Location:
- trunk/Source/WebKit
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebKit/ChangeLog
r256450 r256452 1 2020-02-12 Simon Fraser <simon.fraser@apple.com> 2 3 Pages that trigger a redirect will sometimes be left blank 4 https://bugs.webkit.org/show_bug.cgi?id=207614 5 rdar://problem/59077740 6 7 Reviewed by Tim Horton. 8 9 TiledCoreAnimationDrawingArea::setRootCompositingGraphicsLayer() can be called when the layer tree 10 is frozen, in which case we stash away the layer in m_pendingRootLayer to be parented later at flush 11 time. However, this sequence of calls had a bug: 12 13 setRootCompositingGraphicsLayer() when frozen 14 -> stash in m_pendingRootLayer 15 setRootCompositingGraphicsLayer() when not frozen 16 -> set the root layer 17 flushLayers() 18 -> set the root layer to the (old) m_pendingRootLayer 19 20 So we need to clear m_pendingRootLayer at step 2. 21 22 Very timing dependent, hard to test. 23 24 * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm: 25 (WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer): 26 1 27 2020-02-12 Per Arne Vollan <pvollan@apple.com> 2 28 -
trunk/Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm
r254042 r256452 138 138 } 139 139 140 m_pendingRootLayer = nullptr; 140 141 setRootCompositingLayer(rootLayer); 141 142 }
Note: See TracChangeset
for help on using the changeset viewer.