Changeset 256470 in webkit

Timestamp:

Feb 12, 2020 1:46:36 PM (4 years ago)

Author:

youenn@apple.com

Message:

ServiceWorkerContainer::jobResolvedWithRegistration scopeExit should capture all lambda parameters by value
​https://bugs.webkit.org/show_bug.cgi?id=207657

Reviewed by Chris Dumez.

shouldNotifyWhenResolved is captured by reference in the notifyIfExitEarly ScopeExit lambda.
The ScopeExit is not always called synchronously so it is unsafe to capture values by reference here.

• workers/service/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::jobResolvedWithRegistration):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• workers/service/ServiceWorkerContainer.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-02-12  Youenn Fablet  <youenn@apple.com>
+
+        ServiceWorkerContainer::jobResolvedWithRegistration scopeExit should capture all lambda parameters by value
+        https://bugs.webkit.org/show_bug.cgi?id=207657
+
+        Reviewed by Chris Dumez.
+
+        shouldNotifyWhenResolved is captured by reference in the notifyIfExitEarly ScopeExit lambda.
+        The ScopeExit is not always called synchronously so it is unsafe to capture values by reference here.
+
+        * workers/service/ServiceWorkerContainer.cpp:
+        (WebCore::ServiceWorkerContainer::jobResolvedWithRegistration):
+
 2020-02-12  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/workers/service/ServiceWorkerContainer.cpp

@@ -384 +384 @@
     });
 
-    auto notifyIfExitEarly = WTF::makeScopeExit([this, protectedThis = makeRef(*this), key = data.key, &shouldNotifyWhenResolved] {
+    auto notifyIfExitEarly = WTF::makeScopeExit([this, protectedThis = makeRef(*this), key = data.key, shouldNotifyWhenResolved] {
         if (shouldNotifyWhenResolved == ShouldNotifyWhenResolved::Yes)
             notifyRegistrationIsSettled(key);