Changeset 256569 in webkit

Timestamp:

Feb 13, 2020 3:53:37 PM (4 years ago)

Author:

Keith Rollin

Message:

Add missing call to completionHandler
​https://bugs.webkit.org/show_bug.cgi?id=207720
<rdar://problem/59436915>

Reviewed by Chris Dumez.

Bug 179641 (r225702) updated
SubresourceLoader::willSendRequestInternal with a return call without
first calling the completionHandler. Address this by adding the call
to the completionHandler.

No new tests -- it's not possible to control execution into the
affected code path.

• loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::willSendRequestInternal):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• loader/SubresourceLoader.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-02-13  Keith Rollin  <krollin@apple.com>
+
+        Add missing call to completionHandler
+        https://bugs.webkit.org/show_bug.cgi?id=207720
+        <rdar://problem/59436915>
+
+        Reviewed by Chris Dumez.
+
+        Bug 179641 (r225702) updated
+        SubresourceLoader::willSendRequestInternal with a return call without
+        first calling the completionHandler. Address this by adding the call
+        to the completionHandler.
+
+        No new tests -- it's not possible to control execution into the
+        affected code path.
+
+        * loader/SubresourceLoader.cpp:
+        (WebCore::SubresourceLoader::willSendRequestInternal):
+
 2020-02-13  Tim Horton  <timothy_horton@apple.com>
 

trunk/Source/WebCore/loader/SubresourceLoader.cpp

@@ -240 +240 @@
             if (reachedTerminalState()) {
                 RELEASE_LOG_IF_ALLOWED("willSendRequestinternal: reached terminal state (frame = %p, frameLoader = %p, resourceID = %lu)", frame(), frameLoader(), identifier());
-                return;
+                return completionHandler(WTFMove(newRequest));
             }