Changeset 25694 in webkit

Timestamp:

Sep 21, 2007 4:51:47 PM (17 years ago)

Author:

oliver

Message:

Reviewed by Tristan.

​http://bugs.webkit.org/show_bug.cgi?id=15239
<rdar://problem/5491955> REGRESSION (r25547): With Hanin IME, one cannot input characters into forms (15239)

This problem was caused by the setComposition method failing to clearing
the composition markers in the presence of an empty string. This would
result in the caret being locked within the 0 length bounds of the "composition"
and so preventing basic keyboard interaction.

• editing/Editor.cpp: (WebCore::Editor::setComposition):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• editing/Editor.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2007-09-21  Oliver Hunt  <oliver@apple.com>
+
+        Reviewed by Tristan.
+
+        http://bugs.webkit.org/show_bug.cgi?id=15239
+        <rdar://problem/5491955> REGRESSION (r25547): With Hanin IME, one cannot input characters into forms (15239)
+        
+        This problem was caused by the setComposition method failing to clearing
+        the composition markers in the presence of an empty string.  This would 
+        result in the caret being locked within the 0 length bounds of the "composition"
+        and so preventing basic keyboard interaction.
+
+        * editing/Editor.cpp:
+        (WebCore::Editor::setComposition):
+
 2007-09-21  Adele Peterson  <adele@apple.com>
 

trunk/WebCore/editing/Editor.cpp

@@ -1726 +1726 @@
     deleteSelectionWithSmartDelete(false);
 
+    m_compositionNode = 0;
+    m_customCompositionUnderlines.clear();
+
     if (!text.isEmpty()) {
         TypingCommand::insertText(m_frame->document(), text, true, true);