Changeset 257654 in webkit

Timestamp:

Feb 28, 2020, 1:07:27 PM (6 years ago)

Author:

aakash_jain@apple.com

Message:

EWS fails to retry build in case of kill-old-processes exception
​https://bugs.webkit.org/show_bug.cgi?id=208003

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/ews-build/steps.py:

(KillOldProcesses.evaluateCommand):
(KillOldProcesses.getResultSummary):

Location:

trunk/Tools

Files:

• BuildSlaveSupport/ews-build/steps.py (modified) (1 diff)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/ews-build/steps.py

@@ -1568 +1568 @@
 
     def evaluateCommand(self, cmd):
-        if cmd.didFail():
+        if self.results in [FAILURE, EXCEPTION]:
             self.build.buildFinished(['Failed to kill old processes, retrying build'], RETRY)
         return shell.Compile.evaluateCommand(self, cmd)
 
     def getResultSummary(self):
-        if self.results == FAILURE:
+        if self.results in [FAILURE, EXCEPTION]:
             return {u'step': u'Failed to kill old processes'}
         return shell.Compile.getResultSummary(self)

trunk/Tools/ChangeLog

@@ +1 @@
+2020-02-28  Aakash Jain  <aakash_jain@apple.com>
+
+        EWS fails to retry build in case of kill-old-processes exception
+        https://bugs.webkit.org/show_bug.cgi?id=208003
+
+        Reviewed by Jonathan Bedard.
+
+        * BuildSlaveSupport/ews-build/steps.py:
+        (KillOldProcesses.evaluateCommand):
+        (KillOldProcesses.getResultSummary):
+
 2020-02-28  Aakash Jain  <aakash_jain@apple.com>