Changeset 257928 in webkit

Timestamp:

Mar 5, 2020 10:38:30 AM (4 years ago)

Author:

Alan Bujtas

Message:

[LFC][Integration] Reset position style on line breaks.
​https://bugs.webkit.org/show_bug.cgi?id=208646
<rdar://problem/60086589>

Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/inline/out-of-flow-positioned-line-break.html

We need to treat line breaks as statically positioned inline content.
In the long run we should do something along these lines:
​https://github.com/w3c/csswg-drafts/issues/610

• layout/integration/LayoutIntegrationBoxTree.cpp:

(WebCore::LayoutIntegration::BoxTree::buildTree):

LayoutTests:

• fast/inline/out-of-flow-positioned-line-break-expected.txt: Added.
• fast/inline/out-of-flow-positioned-line-break.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/inline/out-of-flow-positioned-line-break-expected.txt (added)
• LayoutTests/fast/inline/out-of-flow-positioned-line-break.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/layout/integration/LayoutIntegrationBoxTree.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2020-03-05  Zalan Bujtas  <zalan@apple.com>
+
+        [LFC][Integration] Reset position style on line breaks.
+        https://bugs.webkit.org/show_bug.cgi?id=208646
+        <rdar://problem/60086589>
+
+        Reviewed by Antti Koivisto.
+
+        * fast/inline/out-of-flow-positioned-line-break-expected.txt: Added.
+        * fast/inline/out-of-flow-positioned-line-break.html: Added.
+
 2020-03-05  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-03-05  Zalan Bujtas  <zalan@apple.com>
+
+        [LFC][Integration] Reset position style on line breaks.
+        https://bugs.webkit.org/show_bug.cgi?id=208646
+        <rdar://problem/60086589>
+
+        Reviewed by Antti Koivisto.
+
+        Test: fast/inline/out-of-flow-positioned-line-break.html
+
+        We need to treat line breaks as statically positioned inline content.
+        In the long run we should do something along these lines:
+        https://github.com/w3c/csswg-drafts/issues/610
+
+        * layout/integration/LayoutIntegrationBoxTree.cpp:
+        (WebCore::LayoutIntegration::BoxTree::buildTree):
+
 2020-03-05  Eric Carlson  <eric.carlson@apple.com>
 

trunk/Source/WebCore/layout/integration/LayoutIntegrationBoxTree.cpp

@@ -67 +67 @@
             clonedStyle.setDisplay(DisplayType::Inline);
             clonedStyle.setFloating(Float::No);
+            clonedStyle.setPosition(PositionType::Static);
             childBox = makeUnique<Layout::LineBreakBox>(downcast<RenderLineBreak>(childRenderer).isWBR(), WTFMove(clonedStyle));
         }