Changeset 257995 in webkit

Timestamp:

Mar 6, 2020 6:49:38 AM (4 years ago)

Author:

jer.noble@apple.com

Message:

[GPUP] Set the WebProcess's useGPUProcessForMedia setting during the first page load
​https://bugs.webkit.org/show_bug.cgi?id=208694

Reviewed by Youenn Fablet.

Until such a time as we can pass through the correct preference during WebProcess creation,
set the WebProcess's "useGPUProcessForMedia" setting just before the first page load.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):

• WebProcess/WebProcess.h:

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/WebPage/WebPage.cpp (modified) (1 diff)
• WebProcess/WebProcess.cpp (modified) (1 diff)
• WebProcess/WebProcess.h (modified) (2 diffs)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-03-06  Jer Noble  <jer.noble@apple.com>
+
+        [GPUP] Set the WebProcess's useGPUProcessForMedia setting during the first page load
+        https://bugs.webkit.org/show_bug.cgi?id=208694
+
+        Reviewed by Youenn Fablet.
+
+        Until such a time as we can pass through the correct preference during WebProcess creation,
+        set the WebProcess's "useGPUProcessForMedia" setting just before the first page load.
+
+        * WebProcess/WebPage/WebPage.cpp:
+        (WebKit::WebPage::updatePreferences):
+        * WebProcess/WebProcess.cpp:
+        (WebKit::WebProcess::initializeWebProcess):
+        * WebProcess/WebProcess.h:
+
 2020-03-06  Antoine Quint  <graouts@webkit.org>
 

trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp

@@ -3728 +3728 @@
     static_cast<WebMediaStrategy&>(platformStrategies()->mediaStrategy()).setUseGPUProcess(settings.useGPUProcessForMedia());
     WebProcess::singleton().supplement<RemoteMediaPlayerManager>()->updatePreferences(settings);
+    WebProcess::singleton().setUseGPUProcessForMedia(settings.useGPUProcessForMedia());
 #endif
 }

trunk/Source/WebKit/WebProcess/WebProcess.cpp

@@ -473 +473 @@
 #endif
 
-    setUseGPUProcessForMedia(parameters.useGPUProcessForMedia);
-
     RELEASE_LOG_IF_ALLOWED(Process, "initializeWebProcess: Presenting process = %d", WebCore::presentingApplicationPID());
 }

trunk/Source/WebKit/WebProcess/WebProcess.h

@@ -334 +334 @@
 #endif
 
+    void setUseGPUProcessForMedia(bool);
+
 private:
     WebProcess();
@@ -518 +520 @@
     bool isAlwaysOnLoggingAllowed() { return m_sessionID ? m_sessionID->isAlwaysOnLoggingAllowed() : true; }
 
-    void setUseGPUProcessForMedia(bool);
-
     RefPtr<WebConnectionToUIProcess> m_webConnection;