Changeset 258513 in webkit


Ignore:
Timestamp:
Mar 16, 2020 12:56:36 PM (4 years ago)
Author:
Brent Fulgham
Message:

Remove unused IPC messages from DrawingAreaProxy
​https://bugs.webkit.org/show_bug.cgi?id=209090
<rdar://problem/60333300>

Reviewed by Wenson Hsieh.

Do not compile the following three unused messages in DrawingAreaProxy when
building for a Cocoa platform target.

DrawingAreaProxy::Update
DrawingAreaProxy::DidUpdateBackingStoreState
DrawingAreaProxy::ExitAcceleratedCompositingMode

  • UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::enterAcceleratedCompositingMode):
(WebKit::DrawingAreaProxy::update):
(WebKit::DrawingAreaProxy::didUpdateBackingStoreState):
(WebKit::DrawingAreaProxy::exitAcceleratedCompositingMode):

  • UIProcess/DrawingAreaProxy.messages.in:
  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:

(WebKit::TiledCoreAnimationDrawingAreaProxy::exitAcceleratedCompositingMode): Deleted.

Location:
trunk/Source/WebKit
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebKit/ChangeLog

    r258512 r258513  
     12020-03-16  Brent Fulgham  <bfulgham@apple.com>
     2
     3        Remove unused IPC messages from DrawingAreaProxy
     4        https://bugs.webkit.org/show_bug.cgi?id=209090
     5        <rdar://problem/60333300>
     6
     7        Reviewed by Wenson Hsieh.
     8
     9        Do not compile the following three unused messages in DrawingAreaProxy when
     10        building for a Cocoa platform target.
     11
     12        DrawingAreaProxy::Update
     13        DrawingAreaProxy::DidUpdateBackingStoreState
     14        DrawingAreaProxy::ExitAcceleratedCompositingMode
     15
     16        * UIProcess/DrawingAreaProxy.h:
     17        (WebKit::DrawingAreaProxy::enterAcceleratedCompositingMode):
     18        (WebKit::DrawingAreaProxy::update):
     19        (WebKit::DrawingAreaProxy::didUpdateBackingStoreState):
     20        (WebKit::DrawingAreaProxy::exitAcceleratedCompositingMode):
     21        * UIProcess/DrawingAreaProxy.messages.in:
     22        * UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
     23        * UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
     24        (WebKit::TiledCoreAnimationDrawingAreaProxy::exitAcceleratedCompositingMode): Deleted.
     25
    1262020-03-16  Per Arne Vollan  <pvollan@apple.com>
    227

  • trunk/Source/WebKit/UIProcess/DrawingAreaProxy.h

    r253346 r258513  
    11/*
    2  * Copyright (C) 2010-2018 Apple Inc. All rights reserved.
     2 * Copyright (C) 2010-2020 Apple Inc. All rights reserved.
    33 * Portions Copyright (c) 2010 Motorola Mobility, Inc.  All rights reserved.
    44 *
    … …  
    7272    bool setSize(const WebCore::IntSize&, const WebCore::IntSize& scrollOffset = { });
    7373
     74#if !PLATFORM(COCOA)
    7475    // The timeout we use when waiting for a DidUpdateGeometry message.
    7576    static constexpr Seconds didUpdateBackingStoreStateTimeout() { return Seconds::fromMilliseconds(500); }
     77#endif
    7678
    7779    virtual void colorSpaceDidChange() { }
    … …  
    138140    // Message handlers.
    139141    // FIXME: These should be pure virtual.
    140     virtual void update(uint64_t /* backingStoreStateID */, const UpdateInfo&) { }
    141     virtual void didUpdateBackingStoreState(uint64_t /* backingStoreStateID */, const UpdateInfo&, const LayerTreeContext&) { }
    142142    virtual void enterAcceleratedCompositingMode(uint64_t /* backingStoreStateID */, const LayerTreeContext&) { }
    143     virtual void exitAcceleratedCompositingMode(uint64_t /* backingStoreStateID */, const UpdateInfo&) { }
    144143    virtual void updateAcceleratedCompositingMode(uint64_t /* backingStoreStateID */, const LayerTreeContext&) { }
    145144#if PLATFORM(COCOA)
    … …  
    151150    Optional<WebCore::FloatRect> m_lastSentViewExposedRect;
    152151#endif // PLATFORM(MAC)
     152
     153#else
     154    virtual void update(uint64_t /* backingStoreStateID */, const UpdateInfo&) { }
     155    virtual void didUpdateBackingStoreState(uint64_t /* backingStoreStateID */, const UpdateInfo&, const LayerTreeContext&) { }
     156    virtual void exitAcceleratedCompositingMode(uint64_t /* backingStoreStateID */, const UpdateInfo&) { }
    153157#endif
    154158};

  • trunk/Source/WebKit/UIProcess/DrawingAreaProxy.messages.in

    r252655 r258513  
    1 # Copyright (C) 2010, 2011 Apple Inc. All rights reserved.
     1# Copyright (C) 2010-2020 Apple Inc. All rights reserved.
    22#
    33# Redistribution and use in source and binary forms, with or without
    … …  
    2222
    2323messages -> DrawingAreaProxy NotRefCounted {
    24     Update(uint64_t stateID, WebKit::UpdateInfo updateInfo)
    25     DidUpdateBackingStoreState(uint64_t backingStoreStateID, WebKit::UpdateInfo updateInfo, WebKit::LayerTreeContext context)
    2624    EnterAcceleratedCompositingMode(uint64_t backingStoreStateID, WebKit::LayerTreeContext context)
    27     ExitAcceleratedCompositingMode(uint64_t backingStoreStateID, WebKit::UpdateInfo updateInfo)
    2825    UpdateAcceleratedCompositingMode(uint64_t backingStoreStateID, WebKit::LayerTreeContext context)
    2926    DispatchPresentationCallbacksAfterFlushingLayers(Vector<WebKit::CallbackID> callbackIDs);
    … …  
    3330    DidUpdateGeometry()
    3431#endif
     32
     33#if !PLATFORM(COCOA)
     34    Update(uint64_t stateID, WebKit::UpdateInfo updateInfo)
     35    DidUpdateBackingStoreState(uint64_t backingStoreStateID, WebKit::UpdateInfo updateInfo, WebKit::LayerTreeContext context)
     36    ExitAcceleratedCompositingMode(uint64_t backingStoreStateID, WebKit::UpdateInfo updateInfo)
     37#endif
    3538}

  • trunk/Source/WebKit/UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h

    r248522 r258513  
    11/*
    2  * Copyright (C) 2011-2018 Apple Inc. All rights reserved.
     2 * Copyright (C) 2011-2020 Apple Inc. All rights reserved.
    33 *
    44 * Redistribution and use in source and binary forms, with or without
    … …  
    4545
    4646    void enterAcceleratedCompositingMode(uint64_t backingStoreStateID, const LayerTreeContext&) override;
    47     void exitAcceleratedCompositingMode(uint64_t backingStoreStateID, const UpdateInfo&) override;
    4847    void updateAcceleratedCompositingMode(uint64_t backingStoreStateID, const LayerTreeContext&) override;
    4948

  • trunk/Source/WebKit/UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm

    r251445 r258513  
    11/*
    2  * Copyright (C) 2011-2018 Apple Inc. All rights reserved.
     2 * Copyright (C) 2011-2020 Apple Inc. All rights reserved.
    33 *
    44 * Redistribution and use in source and binary forms, with or without
    … …  
    9696}
    9797
    98 void TiledCoreAnimationDrawingAreaProxy::exitAcceleratedCompositingMode(uint64_t backingStoreStateID, const UpdateInfo&)
    99 {
    100     // This should never be called.
    101     ASSERT_NOT_REACHED();
    102 }
    103 
    10498void TiledCoreAnimationDrawingAreaProxy::updateAcceleratedCompositingMode(uint64_t backingStoreStateID, const LayerTreeContext& layerTreeContext)
    10599{
Note: See TracChangeset for help on using the changeset viewer.