Changeset 258586 in webkit

Timestamp:

Mar 17, 2020 1:47:44 PM (4 years ago)

Author:

aakash_jain@apple.com

Message:

[ews-app] Timestamp shown in status-bubble hover-over message is in future
​https://bugs.webkit.org/show_bug.cgi?id=196628

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/ews-build/events.py:

(JSONProducer.json_serialize_datetime): Keep the timestamp in UTC, instead of converting it to local time zone.

• BuildSlaveSupport/ews-app/ews/views/statusbubble.py:

(StatusBubble.get_all_builds_for_queue): Sort the queues based on build number instead of start time, since the
timestamps for new builds might be less than timestamps for old builds which completed immediately prior to this change.

Location:

trunk/Tools

Files:

• BuildSlaveSupport/ews-app/ews/views/statusbubble.py (modified) (1 diff)
• BuildSlaveSupport/ews-build/events.py (modified) (2 diffs)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py

@@ -242 +242 @@
         if not builds:
             return (None, None)
-        builds.sort(key=lambda build: build.started_at, reverse=True)
+        builds.sort(key=lambda build: build.number, reverse=True)
         return (builds, is_parent_build)
 

trunk/Tools/BuildSlaveSupport/ews-build/events.py

@@ -21 +21 @@
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
+import calendar
 import datetime
 import json
@@ -66 +67 @@
         """
         if isinstance(obj, datetime.datetime):
-            return int(time.mktime(obj.timetuple()))
+            return int(calendar.timegm(obj.timetuple()))
 
         raise TypeError("Type %s not serializable" % type(obj))

trunk/Tools/ChangeLog

@@ +1 @@
+2020-03-17  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews-app] Timestamp shown in status-bubble hover-over message is in future
+        https://bugs.webkit.org/show_bug.cgi?id=196628
+
+        Reviewed by Jonathan Bedard.
+
+        * BuildSlaveSupport/ews-build/events.py:
+        (JSONProducer.json_serialize_datetime): Keep the timestamp in UTC, instead of converting it to local time zone.
+        * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
+        (StatusBubble.get_all_builds_for_queue): Sort the queues based on build number instead of start time, since the 
+        timestamps for new builds might be less than timestamps for old builds which completed immediately prior to this change.
+
 2020-03-17  Alex Christensen  <achristensen@webkit.org>