Changeset 258637 in webkit
- Timestamp:
- Mar 18, 2020 8:35:05 AM (4 years ago)
- Location:
- trunk/Tools
- Files:
-
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Tools/BuildSlaveSupport/ews-build/steps.py
r258097 r258637 1333 1333 self.finished(FAILURE) 1334 1334 self.build.results = FAILURE 1335 message = 'Patch does not build' 1335 patch_id = self.getProperty('patch_id', '') 1336 message = 'Patch {} does not build'.format(patch_id) 1336 1337 self.descriptionDone = message 1337 self.build.buildFinished([message], FAILURE) 1338 if self.getProperty('buildername', '').lower() == 'commit-queue': 1339 self.setProperty('bugzilla_comment_text', message) 1340 self.setProperty('build_finish_summary', message) 1341 self.build.addStepsAfterCurrentStep([CommentOnBug(), SetCommitQueueMinusFlagOnPatch()]) 1342 else: 1343 self.build.buildFinished([message], FAILURE) 1338 1344 1339 1345 return defer.succeed(None) -
trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py
r258097 r258637 1062 1062 ] 1063 1063 self.setupStep(AnalyzeCompileWebKitResults(), previous_steps=previous_steps) 1064 self.expectOutcome(result=FAILURE, state_string='Patch does not build (failure)') 1065 return self.runStep() 1064 self.setProperty('patch_id', '1234') 1065 self.expectOutcome(result=FAILURE, state_string='Patch 1234 does not build (failure)') 1066 rc = self.runStep() 1067 self.assertEqual(self.getProperty('bugzilla_comment_text'), None) 1068 self.assertEqual(self.getProperty('build_finish_summary'), None) 1069 return rc 1070 1071 def test_patch_with_build_failure_on_commit_queue(self): 1072 previous_steps = [ 1073 mock_step(CompileWebKit(), results=FAILURE), 1074 mock_step(CompileWebKitToT(), results=SUCCESS), 1075 ] 1076 self.setupStep(AnalyzeCompileWebKitResults(), previous_steps=previous_steps) 1077 self.setProperty('patch_id', '1234') 1078 self.setProperty('buildername', 'commit-queue') 1079 self.expectOutcome(result=FAILURE, state_string='Patch 1234 does not build (failure)') 1080 rc = self.runStep() 1081 self.assertEqual(self.getProperty('bugzilla_comment_text'), 'Patch 1234 does not build') 1082 self.assertEqual(self.getProperty('build_finish_summary'), 'Patch 1234 does not build') 1083 return rc 1066 1084 1067 1085 def test_patch_with_ToT_failure(self): -
trunk/Tools/ChangeLog
r258626 r258637 1 2020-03-18 Aakash Jain <aakash_jain@apple.com> 2 3 [ews] commit-queue should comment on bug in case patch fails to build 4 https://bugs.webkit.org/show_bug.cgi?id=209227 5 6 Reviewed by Jonathan Bedard. 7 8 * BuildSlaveSupport/ews-build/steps.py: 9 (AnalyzeCompileWebKitResults.start): 10 * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test. 11 1 12 2020-03-18 Philippe Normand <pnormand@igalia.com> 2 13
Note: See TracChangeset
for help on using the changeset viewer.