Changeset 258870 in webkit


Ignore:
Timestamp:
Mar 23, 2020 1:19:38 PM (4 years ago)
Author:
Russell Epstein
Message:

[Cocoa] Push applicationSDKVersion() down from WebCore into WTF
​https://bugs.webkit.org/show_bug.cgi?id=209030

Reviewed by Simon Fraser.

Source/JavaScriptCore:

dyld_get_program_sdk_version() gives you the wrong answer in the Web Process (or at least
not the answer you actually want). There are already facilities for the UI Process to tell
the Web Process what the real value is, but those functions are currently in WebCore,
which is inaccessible to WTF. This patch is in preparation for
​https://bugs.webkit.org/show_bug.cgi?id=208969 which needs to know this information in WTF.

I also found a few places which were calling dyld_get_program_sdk_version() in JavaScriptCore
and WebCore (which is wrong because those libraries exist in the Web Process), and have fixed
them up to use applicationSDKVersion() instead.

  • API/JSWrapperMap.mm:

(supportsInitMethodConstructors):

Source/WebCore:

  • html/HTMLObjectElement.cpp:
  • html/MediaElementSession.cpp:

(WebCore::MediaElementSession::requiresFullscreenForVideoPlayback const):

  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::makeCrossOriginAccessRequest):

  • platform/RuntimeApplicationChecks.h:
  • platform/Timer.cpp:

(WebCore::shouldSuppressThreadSafetyCheck):

  • platform/cocoa/RuntimeApplicationChecksCocoa.mm:

(WebCore::applicationSDKVersionOverride): Deleted.
(WebCore::setApplicationSDKVersion): Deleted.
(WebCore::applicationSDKVersion): Deleted.

Source/WebKit:

  • NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):

  • Shared/WebPreferencesDefaultValues.cpp:

(WebKit::defaultCSSOMViewScrollingAPIEnabled):

  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

Source/WTF:

  • WTF.xcodeproj/project.pbxproj:
  • wtf/PlatformMac.cmake:
  • wtf/cocoa/RuntimeApplicationChecksCocoa.cpp: Added.
  • wtf/cocoa/RuntimeApplicationChecksCocoa.h: Added.

(WTF::applicationSDKVersionOverride):
(WTF::setApplicationSDKVersion):
(WTF::applicationSDKVersion):

Location:
branches/safari-609-branch/Source
Files:
2 added
16 edited

Legend:

Unmodified
Added
Removed

  • branches/safari-609-branch/Source/JavaScriptCore/API/JSWrapperMap.mm

    r251425 r258870  
    4141#import "WeakGCMapInlines.h"
    4242#import <wtf/Vector.h>
    43 #import <wtf/spi/darwin/dyldSPI.h>
     43
     44#if PLATFORM(COCOA)
     45#import <wtf/cocoa/RuntimeApplicationChecksCocoa.h>
     46#endif
    4447
    4548#include <mach-o/dyld.h>
    … …  
    721724    static uint32_t programSDKVersion = 0;
    722725    if (!programSDKVersion)
    723         programSDKVersion = dyld_get_program_sdk_version();
     726        programSDKVersion = applicationSDKVersion();
    724727
    725728    return programSDKVersion >= firstSDKVersionWithInitConstructorSupport;

  • branches/safari-609-branch/Source/JavaScriptCore/ChangeLog

    r258591 r258870  
     12020-03-13  Myles C. Maxfield  <mmaxfield@apple.com>
     2
     3        [Cocoa] Push applicationSDKVersion() down from WebCore into WTF
     4        https://bugs.webkit.org/show_bug.cgi?id=209030
     5
     6        Reviewed by Simon Fraser.
     7
     8        dyld_get_program_sdk_version() gives you the wrong answer in the Web Process (or at least
     9        not the answer you actually want). There are already facilities for the UI Process to tell
     10        the Web Process what the real value is, but those functions are currently in WebCore,
     11        which is inaccessible to WTF. This patch is in preparation for
     12        https://bugs.webkit.org/show_bug.cgi?id=208969 which needs to know this information in WTF.
     13
     14        I also found a few places which were calling dyld_get_program_sdk_version() in JavaScriptCore
     15        and WebCore (which is wrong because those libraries exist in the Web Process), and have fixed
     16        them up to use applicationSDKVersion() instead.
     17
     18        * API/JSWrapperMap.mm:
     19        (supportsInitMethodConstructors):
     20
    1212020-03-17  Alan Coon  <alancoon@apple.com>
    222

  • branches/safari-609-branch/Source/WTF/ChangeLog

    r258853 r258870  
     12020-03-13  Myles C. Maxfield  <mmaxfield@apple.com>
     2
     3        [Cocoa] Push applicationSDKVersion() down from WebCore into WTF
     4        https://bugs.webkit.org/show_bug.cgi?id=209030
     5
     6        Reviewed by Simon Fraser.
     7
     8        * WTF.xcodeproj/project.pbxproj:
     9        * wtf/PlatformMac.cmake:
     10        * wtf/cocoa/RuntimeApplicationChecksCocoa.cpp: Added.
     11        * wtf/cocoa/RuntimeApplicationChecksCocoa.h: Added.
     12        (WTF::applicationSDKVersionOverride):
     13        (WTF::setApplicationSDKVersion):
     14        (WTF::applicationSDKVersion):
     15
    116b"2020-03-23  Russell Epstein  <repstein@apple.com>\n\n        Cherry-pick r258658. rdar://problem/60756680\n\n    REGRESSION(r254389): Cordova throws an exception because it expects a hyphen inside navigator.locale\n    https://bugs.webkit.org/show_bug.cgi?id=208969\n    <rdar://problem/59845517>\n    \n    Reviewed by Darin Adler.\n    \n    We want to thwart fingerprinting by minimizing the list of locales, but we also don't want to break existing apps.\n    We can achieve both by a linked-on-or-after check.\n    \n    * wtf/cocoa/LanguageCocoa.mm:\n    (WTF::canMinimizeLanguages):\n    \n    \n    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258658 268f45cc-cd09-0410-ab3c-d52691b4dbfc\n\n    2020-03-18  Myles C. Maxfield  <mmaxfield@apple.com>\n\n            REGRESSION(r254389): Cordova throws an exception because it expects a hyphen inside navigator.locale\n            https://bugs.webkit.org/show_bug.cgi?id=208969\n            <rdar://problem/59845517>\n\n            Reviewed by Darin Adler.\n\n            We want to thwart fingerprinting by minimizing the list of locales, but we also don't want to break existing apps.\n            We can achieve both by a linked-on-or-after check.\n\n            * wtf/cocoa/LanguageCocoa.mm:\n            (WTF::canMinimizeLanguages):\n\n"2020-02-20  Russell Epstein  <repstein@apple.com>
    217

  • branches/safari-609-branch/Source/WTF/WTF.xcodeproj/project.pbxproj

    r254865 r258870  
    6262                1C181C961D30800A00F5FA16 /* TextBreakIteratorInternalICUCocoa.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1C181C951D30800A00F5FA16 /* TextBreakIteratorInternalICUCocoa.cpp */; };
    6363                1C503BE623AAE0AE0072E66B /* LanguageCocoa.mm in Sources */ = {isa = PBXBuildFile; fileRef = 1C503BE523AAE0AE0072E66B /* LanguageCocoa.mm */; };
     64                1CA85CA9241B0B260071C2F5 /* RuntimeApplicationChecksCocoa.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1CA85CA8241B0B260071C2F5 /* RuntimeApplicationChecksCocoa.cpp */; };
    6465                1FA47C8A152502DA00568D1B /* WebCoreThread.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1FA47C88152502DA00568D1B /* WebCoreThread.cpp */; };
    6566                2CCD892A15C0390200285083 /* GregorianDateTime.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 2CCD892915C0390200285083 /* GregorianDateTime.cpp */; };
    … …  
    343344                1C503BE423AADEEA0072E66B /* NSLocaleSPI.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = NSLocaleSPI.h; sourceTree = "<group>"; };
    344345                1C503BE523AAE0AE0072E66B /* LanguageCocoa.mm */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.objcpp; path = LanguageCocoa.mm; sourceTree = "<group>"; };
     346                1CA85CA7241B0B110071C2F5 /* RuntimeApplicationChecksCocoa.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = RuntimeApplicationChecksCocoa.h; sourceTree = "<group>"; };
     347                1CA85CA8241B0B260071C2F5 /* RuntimeApplicationChecksCocoa.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = RuntimeApplicationChecksCocoa.cpp; sourceTree = "<group>"; };
    345348                1CCDB1491E566626006C73C0 /* TextBreakIteratorCF.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = TextBreakIteratorCF.h; sourceTree = "<group>"; };
    346349                1CCDB14D1E566898006C73C0 /* TextBreakIteratorICU.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = TextBreakIteratorICU.h; sourceTree = "<group>"; };
    … …  
    14861489                                5CC0EE882162BC2200A1A842 /* NSURLExtras.mm */,
    14871490                                E392FA2622E92BFF00ECDC73 /* ResourceUsageCocoa.cpp */,
     1491                                1CA85CA8241B0B260071C2F5 /* RuntimeApplicationChecksCocoa.cpp */,
     1492                                1CA85CA7241B0B110071C2F5 /* RuntimeApplicationChecksCocoa.h */,
    14881493                                A30D412C1F0DE0BA00B71954 /* SoftLinking.h */,
    14891494                                5CC0EE862162BC2200A1A842 /* URLCocoa.mm */,
    … …  
    16671672                                2CDED0EF18115C38004DBA70 /* RunLoopCF.cpp in Sources */,
    16681673                                A3EE5C3E21FFAC7D00FABD61 /* RunLoopTimerCF.cpp in Sources */,
     1674                                1CA85CA9241B0B260071C2F5 /* RuntimeApplicationChecksCocoa.cpp in Sources */,
    16691675                                A3EE5C3D21FFAC7D00FABD61 /* SchedulePairCF.cpp in Sources */,
    16701676                                A3EE5C4021FFACA200FABD61 /* SchedulePairMac.mm in Sources */,

  • branches/safari-609-branch/Source/WTF/wtf/PlatformMac.cmake

    r254615 r258870  
    1717    cocoa/Entitlements.h
    1818    cocoa/NSURLExtras.h
     19    cocoa/RuntimeApplicationChecksCocoa.h
    1920    cocoa/SoftLinking.h
    2021
    … …  
    6566    cocoa/NSURLExtras.mm
    6667    cocoa/ResourceUsageCocoa.cpp
     68    cocoa/RuntimeApplicationChecksCocoa.cpp
     69    cocoa/SystemTracingCocoa.cpp
    6770    cocoa/URLCocoa.mm
    6871    cocoa/WorkQueueCocoa.cpp

  • branches/safari-609-branch/Source/WebCore/ChangeLog

    r258856 r258870  
     12020-03-13  Myles C. Maxfield  <mmaxfield@apple.com>
     2
     3        [Cocoa] Push applicationSDKVersion() down from WebCore into WTF
     4        https://bugs.webkit.org/show_bug.cgi?id=209030
     5
     6        Reviewed by Simon Fraser.
     7
     8        * html/HTMLObjectElement.cpp:
     9        * html/MediaElementSession.cpp:
     10        (WebCore::MediaElementSession::requiresFullscreenForVideoPlayback const):
     11        * loader/DocumentThreadableLoader.cpp:
     12        (WebCore::DocumentThreadableLoader::makeCrossOriginAccessRequest):
     13        * platform/RuntimeApplicationChecks.h:
     14        * platform/Timer.cpp:
     15        (WebCore::shouldSuppressThreadSafetyCheck):
     16        * platform/cocoa/RuntimeApplicationChecksCocoa.mm:
     17        (WebCore::applicationSDKVersionOverride): Deleted.
     18        (WebCore::setApplicationSDKVersion): Deleted.
     19        (WebCore::applicationSDKVersion): Deleted.
     20
    121b'2020-03-23  Russell Epstein  <repstein@apple.com>\n\n        Cherry-pick r258799. rdar://problem/60756681\n\n    Content-Type & Nosniff Ignored on XML External Entity Resources\n    <https://webkit.org/b/191171>\n    <rdar://problem/45763222>\n    \n    Reviewed by Darin Adler.\n    \n    Source/WebCore:\n    \n    Test: http/tests/security/contentTypeOptions/nosniff-xml-external-entity.xhtml\n    \n    * platform/MIMETypeRegistry.cpp:\n    (WebCore::MIMETypeRegistry::isXMLEntityMIMEType): Add.\n    * platform/MIMETypeRegistry.h:\n    (WebCore::MIMETypeRegistry::isXMLEntityMIMEType): Add.\n    - Checks for XML external entity MIME types.\n    \n    * xml/parser/XMLDocumentParserLibxml2.cpp:\n    (WebCore::externalEntityMimeTypeAllowedByNosniff): Add.\n    - Checks whether the MIME type is valid based on the presence of\n      the "X-Content-Type-Options: nosniff" header.\n    (WebCore::openFunc):\n    - Drop the contents of the resource that was returned and print\n      an error message to the Web Inspector console if\n      externalEntityMimeTypeAllowedByNosniff() says the MIME type is\n      not allowed.\n    \n    LayoutTests:\n    \n    * http/tests/security/contentTypeOptions/nosniff-xml-external-entity-expected.txt: Add.\n    * http/tests/security/contentTypeOptions/nosniff-xml-external-entity.xhtml: Add.\n    \n    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258799 268f45cc-cd09-0410-ab3c-d52691b4dbfc\n\n    2020-03-20  David Kilzer  <ddkilzer@apple.com>\n\n            Content-Type & Nosniff Ignored on XML External Entity Resources\n            <https://webkit.org/b/191171>\n            <rdar://problem/45763222>\n\n            Reviewed by Darin Adler.\n\n            Test: http/tests/security/contentTypeOptions/nosniff-xml-external-entity.xhtml\n\n            * platform/MIMETypeRegistry.cpp:\n            (WebCore::MIMETypeRegistry::isXMLEntityMIMEType): Add.\n            * platform/MIMETypeRegistry.h:\n            (WebCore::MIMETypeRegistry::isXMLEntityMIMEType): Add.\n            - Checks for XML external entity MIME types.\n\n            * xml/parser/XMLDocumentParserLibxml2.cpp:\n            (WebCore::externalEntityMimeTypeAllowedByNosniff): Add.\n            - Checks whether the MIME type is valid based on the presence of\n              the "X-Content-Type-Options: nosniff" header.\n            (WebCore::openFunc):\n            - Drop the contents of the resource that was returned and print\n              an error message to the Web Inspector console if\n              externalEntityMimeTypeAllowedByNosniff() says the MIME type is\n              not allowed.\n\n    b"2020-03-23  Russell Epstein  <repstein@apple.com>\\n\\n        Cherry-pick r258711. rdar://problem/60756645\\n\\n    Source/WebCore:\\n    AX: VO and safari: can\'t press the play button\\n    https://bugs.webkit.org/show_bug.cgi?id=209249\\n    \\n    Reviewed by Darin Adler.\\n    \\n    Test: accessibility/ios-simulator/has-touch-event-listener-with-shadow.html\\n    \\n    If a node is in a shadowRoot, going up the node parent tree will stop and not check the entire tree for touch event listeners\\n    and a touch event won\'t be dispatched. We need to change to use the parentInComposedTree instead to go up the chain.\\n    \\n    * accessibility/ios/AccessibilityObjectIOS.mm:\\n    (WebCore::AccessibilityObject::hasTouchEventListener const):\\n    \\n    LayoutTests:\\n    AX: VO and safari: caan\'t press the play button\\n    https://bugs.webkit.org/show_bug.cgi?id=209249\\n    \\n    Reviewed by Darin Adler.\\n    \\n    * accessibility/ios-simulator/has-touch-event-listener-with-shadow-expected.txt: Added.\\n    * accessibility/ios-simulator/has-touch-event-listener-with-shadow.html: Added.\\n    \\n    \\n    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258711 268f45cc-cd09-0410-ab3c-d52691b4dbfc\\n\\n    2020-03-19  Chris Fleizach  <cfleizach@apple.com>\\n\\n            AX: VO and safari: can\'t press the play button\\n            https://bugs.webkit.org/show_bug.cgi?id=209249\\n\\n            Reviewed by Darin Adler.\\n\\n            Test: accessibility/ios-simulator/has-touch-event-listener-with-shadow.html\\n\\n            If a node is in a shadowRoot, going up the node parent tree will stop and not check the entire tree for touch event listeners\\n            and a touch event won\'t be dispatched. We need to change to use the parentInComposedTree instead to go up the chain.\\n\\n            * accessibility/ios/AccessibilityObjectIOS.mm:\\n            (WebCore::AccessibilityObject::hasTouchEventListener const):\\n\\n"2020-03-17  Alan Coon  <alancoon@apple.com>\n\n            Apply patch. rdar://problem/60396271\n\n        2020-03-17  Zalan Bujtas  <zalan@apple.com>\n\n                SVG filter triggers unstable layout.\n                https://bugs.webkit.org/show_bug.cgi?id=207444\n                rdar://problem/59297004\n\n                Reviewed by Simon Fraser.\n\n                SVG filter code marks DOM nodes dirty and schedules style recalc outside of the SVG root\n                while in layout. This could lead to unstable layout and cause battery drain.\n                (See webkit.org/b/208903)\n\n                * rendering/RenderLayer.cpp: Remove filterNeedsRepaint(). It\'s a dangerously misleading name and should\n                not be part of RenderLayer.\n                (WebCore::RenderLayer::calculateClipRects const):\n                * rendering/RenderLayer.h:\n                * rendering/RenderLayerFilters.cpp:\n                (WebCore::RenderLayerFilters::notifyFinished):\n                * rendering/svg/RenderSVGResourceContainer.cpp:\n                (WebCore::RenderSVGResourceContainer::markAllClientsForInvalidation):\n                (WebCore::RenderSVGResourceContainer::markAllClientLayersForInvalidation):\n\n'2020-03-17  Alan Coon  <alancoon@apple.com>
    222

  • branches/safari-609-branch/Source/WebCore/html/HTMLObjectElement.cpp

    r249237 r258870  
    5555#if PLATFORM(IOS_FAMILY)
    5656#include "RuntimeApplicationChecks.h"
    57 #include <wtf/spi/darwin/dyldSPI.h>
    5857#endif
    5958

  • branches/safari-609-branch/Source/WebCore/html/MediaElementSession.cpp

    r253397 r258870  
    5454#include "AudioSession.h"
    5555#include "RuntimeApplicationChecks.h"
    56 #include <wtf/spi/darwin/dyldSPI.h>
     56#include <wtf/cocoa/RuntimeApplicationChecksCocoa.h>
    5757#endif
    5858
    … …  
    738738    if (IOSApplication::isIBooks())
    739739        return !m_element.hasAttributeWithoutSynchronization(HTMLNames::webkit_playsinlineAttr) && !m_element.hasAttributeWithoutSynchronization(HTMLNames::playsinlineAttr);
    740     if (dyld_get_program_sdk_version() < DYLD_IOS_VERSION_10_0)
     740    if (applicationSDKVersion() < DYLD_IOS_VERSION_10_0)
    741741        return !m_element.hasAttributeWithoutSynchronization(HTMLNames::webkit_playsinlineAttr);
    742742#endif

  • branches/safari-609-branch/Source/WebCore/loader/DocumentThreadableLoader.cpp

    r256817 r258870  
    6565
    6666#if PLATFORM(IOS_FAMILY)
    67 #include <wtf/spi/darwin/dyldSPI.h>
     67#include <wtf/cocoa/RuntimeApplicationChecksCocoa.h>
    6868#endif
    6969

  • branches/safari-609-branch/Source/WebCore/platform/RuntimeApplicationChecks.h

    r252000 r258870  
    4343bool isInWebProcess();
    4444bool isInNetworkProcess();
    45 
    46 WEBCORE_EXPORT void setApplicationSDKVersion(uint32_t);
    47 WEBCORE_EXPORT uint32_t applicationSDKVersion();
    4845
    4946WEBCORE_EXPORT void setApplicationBundleIdentifier(const String&);

  • branches/safari-609-branch/Source/WebCore/platform/Timer.cpp

    r252651 r258870  
    3838
    3939#if PLATFORM(COCOA)
    40 #include <wtf/spi/darwin/dyldSPI.h>
     40#include <wtf/cocoa/RuntimeApplicationChecksCocoa.h>
    4141#endif
    4242

  • branches/safari-609-branch/Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm

    r252000 r258870  
    6767}
    6868
    69 static Optional<uint32_t>& applicationSDKVersionOverride()
    70 {
    71     static NeverDestroyed<Optional<uint32_t>> version;
    72     return version;
    73 }
    74 
    75 void setApplicationSDKVersion(uint32_t version)
    76 {
    77     applicationSDKVersionOverride() = version;
    78 }
    79 
    80 uint32_t applicationSDKVersion()
    81 {
    82     if (applicationSDKVersionOverride())
    83         return *applicationSDKVersionOverride();
    84     return dyld_get_program_sdk_version();
     69void clearApplicationBundleIdentifierTestingOverride()
     70{
     71    ASSERT(RunLoop::isMain());
     72    applicationBundleIdentifierOverride() = emptyString();
     73#if !ASSERT_MSG_DISABLED
     74    applicationBundleIdentifierOverrideWasQueried = false;
     75#endif
    8576}
    8677

  • branches/safari-609-branch/Source/WebKit/ChangeLog

    r258855 r258870  
     12020-03-13  Myles C. Maxfield  <mmaxfield@apple.com>
     2
     3        [Cocoa] Push applicationSDKVersion() down from WebCore into WTF
     4        https://bugs.webkit.org/show_bug.cgi?id=209030
     5
     6        Reviewed by Simon Fraser.
     7
     8        * NetworkProcess/cocoa/NetworkProcessCocoa.mm:
     9        (WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):
     10        * Shared/WebPreferencesDefaultValues.cpp:
     11        (WebKit::defaultCSSOMViewScrollingAPIEnabled):
     12        * WebProcess/cocoa/WebProcessCocoa.mm:
     13        (WebKit::WebProcess::platformInitializeWebProcess):
     14
    115b'2020-03-23  Russell Epstein  <repstein@apple.com>\n\n        Cherry-pick r258741. rdar://problem/60756641\n\n    Sanitize suggested download filename received from web process\n    https://bugs.webkit.org/show_bug.cgi?id=209300\n    <rdar://problem/59487723>\n    \n    Patch by Alex Christensen <achristensen@webkit.org> on 2020-03-19\n    Reviewed by Chris Dumez.\n    \n    Source/WebKit:\n    \n    * UIProcess/Downloads/DownloadProxy.cpp:\n    (WebKit::DownloadProxy::decideDestinationWithSuggestedFilenameAsync):\n    \n    LayoutTests:\n    \n    * fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-backslash-expected.txt:\n    * fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-backslash.html:\n    \n    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258741 268f45cc-cd09-0410-ab3c-d52691b4dbfc\n\n    2020-03-19  Alex Christensen  <achristensen@webkit.org>\n\n            Sanitize suggested download filename received from web process\n            https://bugs.webkit.org/show_bug.cgi?id=209300\n            <rdar://problem/59487723>\n\n            Reviewed by Chris Dumez.\n\n            * UIProcess/Downloads/DownloadProxy.cpp:\n            (WebKit::DownloadProxy::decideDestinationWithSuggestedFilenameAsync):\n\n'2020-03-23 Russell Epstein  <repstein@apple.com>
    216

  • branches/safari-609-branch/Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm

    r256255 r258870  
    4646#import <wtf/ProcessPrivilege.h>
    4747#import <wtf/RetainPtr.h>
     48#import <wtf/cocoa/RuntimeApplicationChecksCocoa.h>
    4849
    4950namespace WebKit {
    … …  
    7273{
    7374    WebCore::setApplicationBundleIdentifier(parameters.uiProcessBundleIdentifier);
    74     WebCore::setApplicationSDKVersion(parameters.uiProcessSDKVersion);
     75    setApplicationSDKVersion(parameters.uiProcessSDKVersion);
    7576
    7677#if HAVE(HSTS_STORAGE_PATH)

  • branches/safari-609-branch/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp

    r255738 r258870  
    2929
    3030#if PLATFORM(COCOA)
    31 #include <wtf/spi/darwin/dyldSPI.h>
    32 #endif
    33 
    34 #if PLATFORM(IOS_FAMILY)
    3531#include "VersionChecks.h"
     32#include <pal/spi/cocoa/FeatureFlagsSPI.h>
     33#include <wtf/cocoa/RuntimeApplicationChecksCocoa.h>
    3634#endif
    3735
    … …  
    5048{
    5149#if PLATFORM(IOS_FAMILY)
    52     if (WebCore::IOSApplication::isIMDb() && WebCore::applicationSDKVersion() < DYLD_IOS_VERSION_13_0)
     50    if (WebCore::IOSApplication::isIMDb() && applicationSDKVersion() < DYLD_IOS_VERSION_13_0)
    5351        return false;
    5452#endif

  • branches/safari-609-branch/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm

    r256818 r258870  
    8080#import <wtf/ProcessPrivilege.h>
    8181#import <wtf/cocoa/NSURLExtras.h>
     82#import <wtf/cocoa/RuntimeApplicationChecksCocoa.h>
    8283
    8384#if PLATFORM(IOS)
    … …  
    163164
    164165    WebCore::setApplicationBundleIdentifier(parameters.uiProcessBundleIdentifier);
    165     WebCore::setApplicationSDKVersion(parameters.uiProcessSDKVersion);
     166    setApplicationSDKVersion(parameters.uiProcessSDKVersion);
    166167
    167168    m_uiProcessBundleIdentifier = parameters.uiProcessBundleIdentifier;
Note: See TracChangeset for help on using the changeset viewer.