Changeset 258916 in webkit

Timestamp:

Mar 24, 2020 10:20:33 AM (4 years ago)

Author:

commit-queue@webkit.org

Message:

[Web Animations] Clean timeline headers up
​https://bugs.webkit.org/show_bug.cgi?id=209482

Patch by Antoine Quint <Antoine Quint> on 2020-03-24
Reviewed by Antti Koivisto.

The AnimationTimeline::removeAnimationsForElement() method isn't used and DocumentTimeline::applyPendingAcceleratedAnimations()
is only used internally in DocumentTimeline so it can be made private.

• animation/AnimationTimeline.cpp:

(WebCore::AnimationTimeline::removeAnimationsForElement): Deleted.

• animation/AnimationTimeline.h:
• animation/DocumentTimeline.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• animation/AnimationTimeline.cpp (modified) (1 diff)
• animation/AnimationTimeline.h (modified) (1 diff)
• animation/DocumentTimeline.h (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-03-24  Antoine Quint  <graouts@apple.com>
+
+        [Web Animations] Clean timeline headers up
+        https://bugs.webkit.org/show_bug.cgi?id=209482
+
+        Reviewed by Antti Koivisto.
+
+        The AnimationTimeline::removeAnimationsForElement() method isn't used and DocumentTimeline::applyPendingAcceleratedAnimations()
+        is only used internally in DocumentTimeline so it can be made private.
+
+        * animation/AnimationTimeline.cpp:
+        (WebCore::AnimationTimeline::removeAnimationsForElement): Deleted.
+        * animation/AnimationTimeline.h:
+        * animation/DocumentTimeline.h:
+
 2020-03-24  Antoine Quint  <graouts@apple.com>
 

trunk/Source/WebCore/animation/AnimationTimeline.cpp

@@ -194 +194 @@
 }
 
-void AnimationTimeline::removeAnimationsForElement(Element& element)
-{
-    for (auto& animation : animationsForElement(element))
-        animation->remove();
-}
-
 void AnimationTimeline::willChangeRendererForElement(Element& element)
 {

trunk/Source/WebCore/animation/AnimationTimeline.h

@@ -62 +62 @@
 
     void elementWasRemoved(Element&);
-    void removeAnimationsForElement(Element&);
 
     void willChangeRendererForElement(Element&);

trunk/Source/WebCore/animation/DocumentTimeline.h

@@ -67 +67 @@
     bool isRunningAcceleratedAnimationOnRenderer(RenderElement&, CSSPropertyID) const;
     void animationAcceleratedRunningStateDidChange(WebAnimation&);
-    void applyPendingAcceleratedAnimations();
     bool runningAnimationsForElementAreAllAccelerated(Element&) const;
     void detachFromDocument();
@@ -90 +89 @@
 
     DOMHighResTimeStamp liveCurrentTime() const;
+    void applyPendingAcceleratedAnimations();
     void cacheCurrentTime(DOMHighResTimeStamp);
     void maybeClearCachedCurrentTime();