Changeset 259465 in webkit

Timestamp:

Apr 3, 2020 9:43:13 AM (4 years ago)

Author:

Wenson Hsieh

Message:

Add logging to help diagnose <webkit.org/b/209685>
​https://bugs.webkit.org/show_bug.cgi?id=209967

Reviewed by Darin Adler.

Source/WebCore:

Add logging to try and diagnose a handful of API test failures on iOS 13.4 test runners. The failures seem to
only reproduce in release builds on one particular bot; even then, the problem still doesn't reproduce when
running the API tests on this failing bot.

As such, add some logging to try and verify whether...
(1) the UI process is even attempting to update its supported item provider types, which should happen after

each drag session update.

(2) WKContentView is receiving calls to update the drag session in the first place.

• platform/ios/WebItemProviderPasteboard.mm:

(-[WebItemProviderPasteboard updateSupportedTypeIdentifiers:]):

Source/WebKit:

See WebCore/ChangeLog.

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView dropInteraction:sessionDidUpdate:]):

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/platform/ios/WebItemProviderPasteboard.mm (modified) (1 diff)
• WebKit/ChangeLog (modified) (1 diff)
• WebKit/UIProcess/ios/WKContentViewInteraction.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        Add logging to help diagnose <webkit.org/b/209685>
+        https://bugs.webkit.org/show_bug.cgi?id=209967
+
+        Reviewed by Darin Adler.
+
+        Add logging to try and diagnose a handful of API test failures on iOS 13.4 test runners. The failures seem to
+        only reproduce in release builds on one particular bot; even then, the problem still doesn't reproduce when
+        running the API tests on this failing bot.
+
+        As such, add some logging to try and verify whether...
+        (1) the UI process is even attempting to update its supported item provider types, which should happen after
+            each drag session update.
+        (2) WKContentView is receiving calls to update the drag session in the first place.
+
+        * platform/ios/WebItemProviderPasteboard.mm:
+        (-[WebItemProviderPasteboard updateSupportedTypeIdentifiers:]):
+
 2020-04-03  Sihui Liu  <sihui_liu@apple.com>
 

trunk/Source/WebCore/platform/ios/WebItemProviderPasteboard.mm

@@ -493 +493 @@
 - (void)updateSupportedTypeIdentifiers:(NSArray<NSString *> *)types
 {
+    NSLog(@"%s => %@", __PRETTY_FUNCTION__, types);
     _supportedTypeIdentifiers = types;
 }

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        Add logging to help diagnose <webkit.org/b/209685>
+        https://bugs.webkit.org/show_bug.cgi?id=209967
+
+        Reviewed by Darin Adler.
+
+        See WebCore/ChangeLog.
+
+        * UIProcess/ios/WKContentViewInteraction.mm:
+        (-[WKContentView dropInteraction:sessionDidUpdate:]):
+
 2020-04-03  youenn fablet  <youenn@apple.com>
 

trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

@@ -7830 +7830 @@
         proposal = [delegate _webView:self.webView willUpdateDropProposalToProposal:proposal.get() forSession:session];
 
+    NSLog(@"%s => %lu", __PRETTY_FUNCTION__, [proposal operation]);
     return proposal.autorelease();
 }