Changeset 259541 in webkit

Timestamp:

Apr 4, 2020, 5:42:02 PM (5 years ago)

Author:

Wenson Hsieh

Message:

Add a fourth round of logging to help diagnose <webkit.org/b/209685>
​https://bugs.webkit.org/show_bug.cgi?id=210011

Reviewed by Darin Adler.

Source/WebCore:

Augment logging in WebItemProviderPasteboard to additionally dump a backtrace when registering item providers
when initiating a drag on iOS. Logging thus far suggests that this is due to an IPC dispatch race when sending
the following messages to the UI process: WebPasteboardProxy::writeCustomData and
WebPasteboardProxy::writeStringToPasteboard. While writeCustomData is dispatched synchronously,
writeStringToPasteboard is dispatched asynchronously; this means that it is possible for the call to
writeCustomData to be dispatched before writeStringToPasteboard even if the web process sends the
writeCustomData message later, due to the UI-process-side mechanism for immediately dispatching incoming sync
IPC if it is currently processing sync IPC itself.

A backtrace here should help to confirm this theory.

• platform/ios/WebItemProviderPasteboard.mm:

(-[WebItemProviderPasteboard stageRegistrationLists:]):

Source/WebKit:

Remove all logging previously added to WKContentView and DragDropInteractionState.

• UIProcess/ios/DragDropInteractionState.mm:

(WebKit::DragDropInteractionState::stageDragItem):
(WebKit::DragDropInteractionState::clearStagedDragSource):

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _didHandleDragStartRequest:]):

Tools:

Remove all logging previously added to DragAndDropSimulator.

• TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:

(-[DragAndDropSimulator _webView:adjustedDataInteractionItemProvidersForItemProvider:representingObjects:additionalData:]):

Location:

trunk

Files:

• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/platform/ios/WebItemProviderPasteboard.mm (modified) (1 diff)
• Source/WebKit/ChangeLog (modified) (1 diff)
• Source/WebKit/UIProcess/ios/DragDropInteractionState.mm (modified) (2 diffs)
• Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-04-04  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        Add a fourth round of logging to help diagnose <webkit.org/b/209685>
+        https://bugs.webkit.org/show_bug.cgi?id=210011
+
+        Reviewed by Darin Adler.
+
+        Augment logging in WebItemProviderPasteboard to additionally dump a backtrace when registering item providers
+        when initiating a drag on iOS. Logging thus far suggests that this is due to an IPC dispatch race when sending
+        the following messages to the UI process: `WebPasteboardProxy::writeCustomData` and
+        `WebPasteboardProxy::writeStringToPasteboard`. While `writeCustomData` is dispatched synchronously,
+        `writeStringToPasteboard` is dispatched asynchronously; this means that it is possible for the call to
+        `writeCustomData` to be dispatched before `writeStringToPasteboard` even if the web process sends the
+        `writeCustomData` message later, due to the UI-process-side mechanism for immediately dispatching incoming sync
+        IPC if it is currently processing sync IPC itself.
+
+        A backtrace here should help to confirm this theory.
+
+        * platform/ios/WebItemProviderPasteboard.mm:
+        (-[WebItemProviderPasteboard stageRegistrationLists:]):
+
 2020-04-04  Doug Kelly  <dougk@apple.com>
 

trunk/Source/WebCore/platform/ios/WebItemProviderPasteboard.mm

@@ -858 +858 @@
     ASSERT(lists.count);
     NSLog(@"%s - %@", __PRETTY_FUNCTION__, lists);
+    WTFReportBacktrace();
     _stagedRegistrationInfoLists = lists;
 }

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-04-04  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        Add a fourth round of logging to help diagnose <webkit.org/b/209685>
+        https://bugs.webkit.org/show_bug.cgi?id=210011
+
+        Reviewed by Darin Adler.
+
+        Remove all logging previously added to WKContentView and DragDropInteractionState.
+
+        * UIProcess/ios/DragDropInteractionState.mm:
+        (WebKit::DragDropInteractionState::stageDragItem):
+        (WebKit::DragDropInteractionState::clearStagedDragSource):
+        * UIProcess/ios/WKContentViewInteraction.mm:
+        (-[WKContentView _didHandleDragStartRequest:]):
+
 2020-04-04  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebKit/UIProcess/ios/DragDropInteractionState.mm

@@ -340 +340 @@
 void DragDropInteractionState::stageDragItem(const DragItem& item, UIImage *dragImage)
 {
-    NSLog(@"%s - source action := %02x", __PRETTY_FUNCTION__, item.sourceAction);
     static NSInteger currentDragSourceItemIdentifier = 0;
 
@@ -365 +364 @@
 void DragDropInteractionState::clearStagedDragSource(DidBecomeActive didBecomeActive)
 {
-    if (m_stagedDragSource)
-        NSLog(@"%s - source action := %02x", __PRETTY_FUNCTION__, m_stagedDragSource->action);
-
     if (didBecomeActive == DidBecomeActive::Yes)
         m_activeDragSources.append(stagedDragSource());

trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

@@ -7080 +7080 @@
     ASSERT(savedCompletionBlock);
 
-    NSLog(@"Handling drag start request (started: %d, completion block: %p)", started, savedCompletionBlock.get());
+    RELEASE_LOG(DragAndDrop, "Handling drag start request (started: %d, completion block: %p)", started, savedCompletionBlock.get());
     if (savedCompletionBlock)
         savedCompletionBlock();

trunk/Tools/ChangeLog

@@ +1 @@
+2020-04-04  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        Add a fourth round of logging to help diagnose <webkit.org/b/209685>
+        https://bugs.webkit.org/show_bug.cgi?id=210011
+
+        Reviewed by Darin Adler.
+
+        Remove all logging previously added to DragAndDropSimulator.
+
+        * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
+        (-[DragAndDropSimulator _webView:adjustedDataInteractionItemProvidersForItemProvider:representingObjects:additionalData:]):
+
 2020-04-04  Chris Dumez  <cdumez@apple.com>
 

trunk/Tools/TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm

@@ -608 +608 @@
         NSArray *items = [[_webView dragInteractionDelegate] dragInteraction:[_webView dragInteraction] itemsForBeginningSession:_dragSession.get()];
         if (!items.count) {
-            NSLog(@"%s (found no drag items when beginning session)", __PRETTY_FUNCTION__);
             _phase = DragAndDropPhaseCancelled;
             _currentProgress = 1;
@@ -899 +898 @@
 - (NSArray *)_webView:(WKWebView *)webView adjustedDataInteractionItemProvidersForItemProvider:(NSItemProvider *)itemProvider representingObjects:(NSArray *)representingObjects additionalData:(NSDictionary *)additionalData
 {
-    NSLog(@"%s - self.convertItemProvidersBlock := %p; itemProvider.registeredTypeIdentifiers := %@", __PRETTY_FUNCTION__, self.convertItemProvidersBlock, itemProvider.registeredTypeIdentifiers);
     return self.convertItemProvidersBlock ? self.convertItemProvidersBlock(itemProvider, representingObjects, additionalData) : @[ itemProvider ];
 }