Changeset 259569 in webkit


Ignore:
Timestamp:
Apr 6, 2020 8:16:39 AM (4 years ago)
Author:
graouts@webkit.org
Message:

[macOS] TestWebKitAPI.WKUserContentController.UserStyleSheetAffectingOnlySpecificWebViewSharedConfiguration is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=209934
<rdar://problem/61229832>

Reviewed by Antti Koivisto.

Fix a couple of tests which would use -[WKWebView _test_waitForDidFinishNavigation] in a way where the navigation may have finished before the method was called.

  • TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:

(TEST):

Location:
trunk/Tools
Files:
2 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/ChangeLog

    r259565 r259569  
     12020-04-06  Antoine Quint  <graouts@apple.com>
     2
     3        [macOS] TestWebKitAPI.WKUserContentController.UserStyleSheetAffectingOnlySpecificWebViewSharedConfiguration is a flaky timeout
     4        https://bugs.webkit.org/show_bug.cgi?id=209934
     5        <rdar://problem/61229832>
     6
     7        Reviewed by Antti Koivisto.
     8
     9        Fix a couple of tests which would use `-[WKWebView _test_waitForDidFinishNavigation]` in a way where the navigation may have finished before the method was called.
     10
     11        * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
     12        (TEST):
     13
    1142020-04-05  Gus Caplan  <me@gus.host> and Ross Kirsling  <ross.kirsling@sony.com>
    215

  • trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm

    r259523 r259569  
    514514
    515515    [targetWebView loadHTMLString:@"<body style='background-color: red;'></body>" baseURL:nil];
     516    [targetWebView _test_waitForDidFinishNavigation];
     517
    516518    [otherWebView loadHTMLString:@"<body style='background-color: red;'></body>" baseURL:nil];
    517 
    518     [targetWebView _test_waitForDidFinishNavigation];
    519519    [otherWebView _test_waitForDidFinishNavigation];
    520520
    … …  
    567567
    568568    [targetWebView loadHTMLString:@"<body style='background-color: red;'></body>" baseURL:nil];
     569    [targetWebView _test_waitForDidFinishNavigation];
     570
    569571    [otherWebView loadHTMLString:@"<body style='background-color: red;'></body>" baseURL:nil];
    570 
    571     [targetWebView _test_waitForDidFinishNavigation];
    572572    [otherWebView _test_waitForDidFinishNavigation];
    573573
Note: See TracChangeset for help on using the changeset viewer.